test: replace forEach with for..of in test-net-isipv6.js#49823
Closed
niyashiyas wants to merge 4 commits intonodejs:mainfrom
Closed
test: replace forEach with for..of in test-net-isipv6.js#49823niyashiyas wants to merge 4 commits intonodejs:mainfrom
niyashiyas wants to merge 4 commits intonodejs:mainfrom
Conversation
nodejs-github-bot
added
needs-ci
tniessen
added
the
code-and-learn
tniessen
reviewed
Sep 23, 2023
test/parallel/test-net-isipv6.js
Outdated
| for(const ip of v6) { | ||
| assert.strictEqual(net.isIPv6(ip), true); | ||
| }); | ||
| }; |
Contributor
Author
There was a problem hiding this comment.
Made required changes.
test/parallel/test-net-isipv6.js
Outdated
| for(const ip of v6not) { | ||
| assert.strictEqual(net.isIPv6(ip), false); | ||
| }); | ||
| }; |
Contributor
Author
There was a problem hiding this comment.
Made required changes.
Contributor
Author
|
Please review this again. |
niyashiyas
changed the title
lpinca
approved these changes
Oct 7, 2023
lpinca
added
commit-queue-squash
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
This was referenced Oct 8, 2023
Collaborator
This was referenced Oct 10, 2023
lpinca
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/49823 ✔ Done loading data for nodejs/node/pull/49823 ----------------------------------- PR info ------------------------------------ Title test: replace forEach with for..of in test-net-isipv6.js (#49823) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch niyashiyas:test-7 -> nodejs:main Labels test, code-and-learn, needs-ci, commit-queue-squash Commits 4 - test: replace forEach with for..of in test-net-isipv6.js - test: replace forEach with for..of in test-net-isipv6.js - Update test/parallel/test-net-isipv6.js - Update test/parallel/test-net-isipv6.js Committers 2 - Niya Shiyas - GitHub PR-URL: https://github.com/nodejs/node/pull/49823 Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/49823 Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - Update test/parallel/test-net-isipv6.js ⚠ - Update test/parallel/test-net-isipv6.js ℹ This PR was created on Sat, 23 Sep 2023 08:56:26 GMT ✔ Approvals: 1 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/49823#pullrequestreview-1663033007 ℹ This PR is being fast-tracked because it is from a Code and Learn event ✔ Last GitHub CI successful ℹ Last Full PR CI on 2023-10-09T13:17:19Z: https://ci.nodejs.org/job/node-test-pull-request/54630/ - Querying data for job/node-test-pull-request/54630/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/6509223254 |
lpinca
pushed a commit
that referenced
this pull request
Oct 13, 2023
PR-URL: #49823 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Member
|
Landed in 41e4174. |
alexfernandez
pushed a commit
to alexfernandez/node
that referenced
this pull request
Nov 1, 2023
PR-URL: nodejs#49823 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Nov 11, 2023
PR-URL: #49823 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced forEach with for..of in test-net-isipv6.js