Skip to content

permission: fix recent coverity warning #48775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mhdawson wants to merge 2 commits into from
Closed

permission: fix recent coverity warning #48775

mhdawson wants to merge 2 commits into from

Conversation

@mhdawson
Copy link
Member

@mhdawson mhdawson commented Jul 14, 2023

  • address recent coverity warning by using auto &. Since the value is already const using a copy should not be necessary.

@mhdawson
permission: fix recent coverity warning
56ed8d9 
- address recent coverity warning by using auto &.
  Since the value is already const using a copy
  should not be necessary.

Signed-off-by: Michael Dawson <mdawson@devrus.com>
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 14, 2023

Review requested:

  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Jul 14, 2023
@mhdawson mhdawson requested a review from RafaelGSS July 14, 2023 18:58
@mhdawson
Copy link
Member Author

mhdawson commented Jul 14, 2023

This is the reported coverity warning:

   if (node->children.size()) {
 93      int child = 0;
   	
CID 322084 (#1 of 1): AUTO_CAUSES_COPY (AUTO_CAUSES_COPY)
1. auto_causes_copy: Using the auto keyword without an & causes the copy of an object of type pair.
   	Use auto & instead of auto.
 94      for (const auto pair : node->children) {

Since pair is const, it seems to make sense to avoid a copy byusing auto &

@RafaelGSS
Copy link
Member

RafaelGSS commented Jul 14, 2023

See: #48770

@mhdawson
squash: address linter complaints
5b2ada4 
Signed-off-by: Michael Dawson <mdawson@devrus.com>
@mhdawson
Copy link
Member Author

mhdawson commented Jul 18, 2023

ok see its been covered.

@mhdawson mhdawson closed this Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RafaelGSS RafaelGSS Awaiting requested review from RafaelGSS

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mhdawson @nodejs-github-bot @RafaelGSS