Skip to content

[v18.x] test: mark test-child-process-stdio-reuse-readable-stdio flaky #48601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
juanarbol wants to merge 2 commits into from
Closed

[v18.x] test: mark test-child-process-stdio-reuse-readable-stdio flaky #48601

juanarbol wants to merge 2 commits into from

Conversation

@juanarbol
Copy link
Member

@juanarbol juanarbol commented Jun 29, 2023

As mentioned #48345 (comment), this PR includes the current v18.x release line blockers to get any PR landed there. I hope this fixes the problems :)

MoLow and others added 2 commits June 29, 2023 09:56
@MoLow @juanarbol
test: mark test-child-process-pipe-dataflow as flaky
137f1cd 
PR-URL: nodejs#48334
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@lpinca @juanarbol
test: mark test-child-process-stdio-reuse-readable-stdio flaky
5daa07a 
Refs: nodejs#48300 (comment)
Refs: nodejs/reliability#597 (comment)
PR-URL: nodejs#48537
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch. labels Jun 29, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 29, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/52561/

mhdawson
mhdawson approved these changes Jun 29, 2023
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juanarbol juanarbol added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 1, 2023
@StefanStojanovic StefanStojanovic mentioned this pull request Jul 4, 2023
Closed
@juanarbol
Copy link
Member Author

juanarbol commented Jul 4, 2023

Landed in fb90b6b...2edd0fd

@juanarbol juanarbol closed this Jul 4, 2023
@juanarbol juanarbol deleted the v18.x-staging-flaky-tests branch December 6, 2023 03:27
@panva panva removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes

@anonrig anonrig anonrig approved these changes

@mhdawson mhdawson mhdawson approved these changes

@StefanStojanovic StefanStojanovic StefanStojanovic approved these changes

Assignees

No one assigned

Labels

needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@juanarbol @nodejs-github-bot @lpinca @anonrig @mhdawson @StefanStojanovic @panva @MoLow