Review requested:

• @nodejs/single-executable

Thanks for the PR!

We're using the hello name without the extension for the Windows commands in a couple more places in the documentation. Would be nice if we could update those too -

• hello -> hello.exe -

  node/doc/api/single-executable-applications.md

  Line 64 in 595b2b3

  $ signtool remove /s hello

• `hello` -> `hello` / `hello.exe` :

  node/doc/api/single-executable-applications.md

  Line 70 in 595b2b3

  * `hello` - The name of the copy of the `node` executable created in step 2.

• For this one we could probably create another copy for Windows and use the hello.exe name there and state that this one is for Linux only -

  node/doc/api/single-executable-applications.md

  Lines 82 to 86 in 595b2b3

  	* On systems other than macOS:
  	```console
  	$ npx postject hello NODE_SEA_BLOB sea-prep.blob \
  	--sentinel-fuse NODE_SEA_FUSE_fce680ab2cc467b6e072b8b5df1996b2
  	```

• hello -> hello.exe -

  node/doc/api/single-executable-applications.md

  Line 109 in 595b2b3

  $ signtool sign /fd SHA256 hello

• Maybe a separate command that does .\hello.exe world on Windows:

  node/doc/api/single-executable-applications.md

  Line 114 in 595b2b3

  $ ./hello world

Also, do you mind using doc instead of docs for the first commit? The commit validator in CI would fail otherwise and this would require a manual landing then. It's fine if you don't wanna do it, I can handle it while landing. :)

The step reference of copying node executable may be wrong, and I also fix it in 00454f5

Another question is in some windows with powershell, the default encoding is UTF-16. That is to say in the step 1 and 2, the encoding of echoed hello.js and sea-config.json is UTF-16. I am not sure whether it will cause some unintended errors. (I have no environment to test it now)

I think UTF-16 too should be okay because we have a test that uses a UTF-16 character in the SEA -

I reckon where.exe node also gets the job done

I reckon where.exe node also gets the job done

It works in cmd.

I also searched equivalent of Bash's $(), and write the following command to copy node, but I am not sure whether there is a better or eleganter command in windows cmd.

for /F "tokens=*" %n IN ('where.exe node') DO @(copy "%n" hello.exe)

@nodejs/platform-windows any thoughts on ^?

@yjl9903 FWIW, if this works on cmd, I'm in favor of using this command for the Windows docs because then we'll have a command that would work both on cmd as well as powershell on Windows. If someone else knows of a more elegant way of doing this, maybe that could be done in a separate PR later?

@yjl9903 FWIW, if this works on cmd, I'm in favor of using this command for the Windows docs because then we'll have a command that would work both on cmd as well as powershell on Windows. If someone else knows of a more elegant way of doing this, maybe that could be done in a separate PR later?

Done.

#47722 merged to this PR

@yjl9903 unfortunately, our tooling doesn't support merge commits yet, so you might need to go for a rebase instead

Oh, I think I am not very familiar with how to do rebasing... How to reopen this PR @RaisinTen ?

@yjl9903 could you try checking if https://gist.github.com/robertpainsi/2c42c15f1ce6dab03a0675348edd4e2c helps? So IIUC, you would need to run:

git push -f origin b31d587dc8c1b0f459243d2b96a17a7175c996cf:patch-1
# Reopen the PR.
git push -f origin 45c4698fa56d28579009de9d78a1f41b372689ec:patch-1

Alternatively, you could also try to click on "Create pull request" in main...yjl9903:node:patch-1, which would help you create a new pull request with the current list of commits that are present on your branch.