build: refactor Android build system by MeowShe · Pull Request #44207 · nodejs/node

MeowShe · 2022-08-11T03:29:24Z

Completely rewritten the Android build process in Python to make it more complete and CI ready.

Supported building node for android on macOS (Intel)

Refs: #36287

tniessen · 2022-08-23T14:10:29Z

cc @nodejs/build

MeowShe · 2022-08-30T16:14:38Z

cc @nodejs/build

Is there anything I can do to advance this pull request plz?

tniessen · 2022-09-04T15:01:55Z

I'm very sorry about the lack of activity on the project's side here. I'm afraid I don't know if any of the current project members actively maintain support for Android. There is no platform team for Android, and android-configure appears to be modified about once a year only.

I'm going to try pinging those folks who approved previous PRs: @cclauss @devnexen @F3n67u @yashLadha @bnoordhuis

cclauss · 2022-09-04T15:06:02Z

I do know Android so I have not commented.

F3n67u · 2022-09-05T06:51:29Z

+    sys.exit(0)
+
+if len(sys.argv) != 4:
+    print("Usage: ./android-configure [patch] <path to the Android NDK> <Android SDK version> <target architecture>")


Shall we update https://github.com/nodejs/node/blob/main/BUILDING.md#android accordingly?

Yes, but in this branch, BUILDING.md is out of date, do I need to create a new branch and pull requests to update it or later?

I think it would be better to update this doc in the same pr.

Hi, @MeowShe. Would you update BUILDING.md in this pr?

Hi, @MeowShe. Would you update BUILDING.md in this pr?

I want but I don't seem to know how to do it because the BUILDING.md in this branch is out of date and if I update BUILDING.md it will cause a conflict and I will have to merge main branch to solve it, but the nodejs Pull Request CI doesn't seem to allow me to do that.

Thanks, I will update BUILDING.md using rebase when all the fix are ready.

@MeowShe would you mind update the BUILDING.md to keep the doc update with this change?

I will open a new pull request to update it, and a macOS build fix will be included, thank you.

Thanks. A person asked me in an email if android configure is supported in the latest main branch. So I remember our BUILING.md if lost updated with our codebase.😃

I will commit those changes ASAP 😃

F3n67u · 2022-09-05T09:02:13Z

I tried to build with this change on macOS (Intel), but got the following error:

$ ./android-configure ~/Library/Android/sdk/ndk/25.1.8937393 28 x86_64
$ make
rm -f /Users/feng/dev/node/out/Release/obj.target/tools/icu/libicuucx.a ar-file-list; mkdir -p `dirname /Users/feng/dev/node/out/Release/obj.target/tools/icu/libicuucx.a`
ar crsT /Users/feng/dev/node/out/Release/obj.target/tools/icu/libicuucx.a @/Users/feng/dev/node/out/Release/obj.target/tools/icu/libicuucx.a.ar-file-list
ar: @/Users/feng/dev/node/out/Release/obj.target/tools/icu/libicuucx.a.ar-file-list: No such file or directory
make[1]: *** [/Users/feng/dev/node/out/Release/obj.target/tools/icu/libicuucx.a] Error 1
make: *** [node] Error 2

Do you have any idea why this error happened?

Completely rewritten the Android build system using Python Co-Authored-By: 东灯 <43312495+Lampese@users.noreply.github.com> Co-Authored-By: Feng Yu <F3n67u@outlook.com>

F3n67u · 2022-09-05T10:56:24Z

I tried to build with this change on macOS (Intel), but got the following error:

$ ./android-configure ~/Library/Android/sdk/ndk/25.1.8937393 28 x86_64
$ make
rm -f /Users/feng/dev/node/out/Release/obj.target/tools/icu/libicuucx.a ar-file-list; mkdir -p `dirname /Users/feng/dev/node/out/Release/obj.target/tools/icu/libicuucx.a`
ar crsT /Users/feng/dev/node/out/Release/obj.target/tools/icu/libicuucx.a @/Users/feng/dev/node/out/Release/obj.target/tools/icu/libicuucx.a.ar-file-list
ar: @/Users/feng/dev/node/out/Release/obj.target/tools/icu/libicuucx.a.ar-file-list: No such file or directory
make[1]: *** [/Users/feng/dev/node/out/Release/obj.target/tools/icu/libicuucx.a] Error 1
make: *** [node] Error 2

Do you have any idea why this error happened?

I cannot build for Android with main branch too, so feel free to ignore this comment.

cclauss · 2022-09-05T10:57:34Z

+    print("- Patches List -")
+    print("[1] [deps/v8/src/trap-handler/trap-handler.h] related to https://github.com/nodejs/node/issues/36287")
+    if platform.system() == "Linux":
+        os.system('patch -f ./deps/v8/src/trap-handler/trap-handler.h < ./android-patches/trap-handler.h.patch')


Please use subprocess.run() instead of os.system() for security and compatibility reasons.

https://docs.python.org/3/library/subprocess.html#subprocess.run

tniessen · 2022-09-26T18:13:16Z

Thanks for the contribution @MeowShe.

xeoshow · 2022-10-07T03:20:01Z

Hello @MeowShe ,
I am new to nodejs on android, does this pr mean we could use nodejs on android? If so, is there any binary out of the box that we could install on the centOS 7.6 or some linux? If not, is there any guide to how to build it for centOS or linux?And is there any tutorial or document for how to use it on linux?

Great thanks!

Best regards, Jason

MeowShe · 2022-10-07T04:52:16Z

Hello @MeowShe ,

I am new to nodejs on android, does this pr mean we could use nodejs on android? If so, is there any binary out of the box that we could install on the centOS 7.6 or some linux? If not, is there any guide to how to build it for centOS or linux?And is there any tutorial or document for how to use it on linux?

Great thanks!

Best regards, Jason

Yes, now we can run node applications on Android, if you've asking how to build Node.js binary for Android on CentOS, just follow BUILDING.md please.

Alternatively, you may want to look at #44888, which is a pull request in progress that has not yet been merged.

xeoshow · 2022-10-07T05:07:49Z

Thanks for help @MeowShe , By BUILDING.md, you mean exactly the below link? After building, what is the result output we will get? A binary file we could just execute? Thanks again!

https://github.com/MeowShe/node/blob/android-build/BUILDING.md#android

MeowShe · 2022-10-07T05:10:55Z

Thanks for help @MeowShe , By BUILDING.md, you mean exactly the below link? After building, what is the result output we will get? A binary file we could just execute? Thanks again!

https://github.com/MeowShe/node/blob/android-build/BUILDING.md#android

Yes, a binary can be executed on Android will be built, then you can use ProcessBuilder (Android API) or any other ways to run it.

Sanoussi85 · 2023-12-27T23:52:02Z

#44207 (comment)

nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. labels Aug 11, 2022

MeowShe closed this Aug 11, 2022

MeowShe reopened this Aug 11, 2022

MeowShe force-pushed the android-configure branch 4 times, most recently from 8ef2283 to 4e6f250 Compare August 15, 2022 08:29

MeowShe changed the title ~~build: improved build for Android platform~~ build: refactored Android build system Aug 16, 2022

MeowShe force-pushed the android-configure branch 2 times, most recently from 12b559b to dc5aad2 Compare August 17, 2022 00:05

MeowShe closed this Sep 4, 2022

MeowShe reopened this Sep 5, 2022

F3n67u added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 5, 2022

F3n67u reviewed Sep 5, 2022

View reviewed changes

Comment thread android_configure.py Outdated

F3n67u removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 5, 2022

MeowShe requested a review from F3n67u September 5, 2022 06:05

F3n67u reviewed Sep 5, 2022

View reviewed changes

F3n67u suggested changes Sep 5, 2022

View reviewed changes

Comment thread android_configure.py Outdated

Comment thread android_configure.py Outdated

Comment thread android_configure.py Outdated

build: rewritten the Android build system

cdca8cf

Completely rewritten the Android build system using Python Co-Authored-By: 东灯 <43312495+Lampese@users.noreply.github.com> Co-Authored-By: Feng Yu <F3n67u@outlook.com>

MeowShe force-pushed the android-configure branch from c2c8fcd to cdca8cf Compare September 5, 2022 10:44

cclauss reviewed Sep 5, 2022

View reviewed changes

Comment thread android_configure.py Outdated

F3n67u changed the title ~~build: refactored Android build system~~ build: refactor Android build system Sep 5, 2022

MeowShe deleted the android-configure branch September 12, 2022 10:16

This was referenced Sep 13, 2022

CI Reliability 2022-09-13 nodejs/reliability#376

Open

CI Reliability 2022-09-14 nodejs/reliability#378

Open

CI Reliability 2022-09-15 nodejs/reliability#379

Open

This was referenced Sep 16, 2022

CI Reliability 2022-09-16 nodejs/reliability#380

Open

CI Reliability 2022-09-17 nodejs/reliability#381

Open

RafaelGSS mentioned this pull request Sep 26, 2022

v18.10.0 proposal #44799

Merged

juanarbol mentioned this pull request Oct 4, 2022

V16.18.0 proposal #44886

Merged

MeowShe mentioned this pull request Oct 4, 2022

doc: improve building doc for Android #44888

Merged

Uh oh!

Conversation

MeowShe commented Aug 11, 2022 • edited by F3n67u Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tniessen commented Aug 23, 2022

Uh oh!

MeowShe commented Aug 30, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tniessen commented Sep 4, 2022

Uh oh!

cclauss commented Sep 4, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

F3n67u commented Sep 5, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

F3n67u commented Sep 5, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

tniessen commented Sep 26, 2022

Uh oh!

xeoshow commented Oct 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MeowShe commented Oct 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

xeoshow commented Oct 7, 2022

Uh oh!

MeowShe commented Oct 7, 2022

Uh oh!

Sanoussi85 commented Dec 27, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

MeowShe commented Aug 11, 2022 •

edited by F3n67u

Loading

MeowShe commented Aug 30, 2022 •

edited

Loading

xeoshow commented Oct 7, 2022 •

edited

Loading

MeowShe commented Oct 7, 2022 •

edited

Loading