Skip to content

[v18.x]: deps: V8: PPC: pass a scratch register when using register_location #44107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
miladfarca wants to merge 1 commit into from
Closed

[v18.x]: deps: V8: PPC: pass a scratch register when using register_location #44107

miladfarca wants to merge 1 commit into from

Conversation

@miladfarca
Copy link
Contributor

@miladfarca miladfarca commented Aug 2, 2022

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 2, 2022

Review requested:

  • @nodejs/gyp
  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch. v8 engine Issues and PRs related to the V8 dependency. labels Aug 2, 2022
@kvakil
Copy link
Contributor

kvakil commented Aug 3, 2022 •
edited
Loading

Thanks for the fix! Some notes:

  1. v18.x is the current branch, so I don't think you need to include [v18.x], and you shouldn't merge to v18.x-staging but main instead. The change will get picked up by the next release.
  2. There are some instructions here about how to create a commit message following the correct format here.
  3. Could you add Fixes: https://github.com/nodejs/node/issues/44055 to the commit message, so that future readers can understand why this patch was created?

@kvakil kvakil added the ppc Issues and PRs related to the Power architecture. label Aug 3, 2022
@miladfarca
Copy link
Contributor Author

miladfarca commented Aug 3, 2022

Thank you, I've created a PR on main #44115 , will close this.

@miladfarca miladfarca closed this Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. ppc Issues and PRs related to the Power architecture. v8 engine Issues and PRs related to the V8 dependency. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@miladfarca @nodejs-github-bot @kvakil