doc: add note about pip being required#40669
Closed
PiotrRybak wants to merge 4 commits intonodejs:masterfrom
Closed
doc: add note about pip being required#40669PiotrRybak wants to merge 4 commits intonodejs:masterfrom
PiotrRybak wants to merge 4 commits intonodejs:masterfrom
Conversation
nodejs-github-bot
added
build
PiotrRybak
commented
Oct 31, 2021
mscdex
reviewed
Oct 31, 2021
BUILDING.md
Outdated
|
|
||
| * Xcode Command Line Tools >= 11 for macOS | ||
| * Python 3.6, 3.7, 3.8, 3.9, or 3.10 (see note above) | ||
| * Python 3.6, 3.7, 3.8, 3.9, or 3.10 (see note above) with pip installed |
Contributor
There was a problem hiding this comment.
This and the package references above should be changed as well.
Contributor
Author
There was a problem hiding this comment.
I've updated this and moved the pip install packages to the end of package list (so it's slightly easier to remove them if someone doesn't want them).
It feels that it's better to keep them together than make the install instructions longer with 2 versions, but please let me know if you disagree.
PiotrRybak
force-pushed
the
building-update
branch
from
89b4d5e to
c312b10
Compare
Clean install requires pip to make coverage but instructions didn't mention it.
PiotrRybak
force-pushed
the
building-update
branch
from
c312b10 to
293e518
Compare
lpinca
approved these changes
Nov 7, 2021
jasnell
approved these changes
Nov 13, 2021
Ayase-252
added
the
author ready
aduh95
pushed a commit
that referenced
this pull request
Dec 10, 2021
Clean install requires pip to make coverage but instructions didn't mention it. PR-URL: #40669 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Contributor
|
Landed in c4aed2f |
danielleadams
pushed a commit
that referenced
this pull request
Dec 13, 2021
Clean install requires pip to make coverage but instructions didn't mention it. PR-URL: #40669 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Dec 14, 2021
Clean install requires pip to make coverage but instructions didn't mention it. PR-URL: #40669 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 31, 2022
Clean install requires pip to make coverage but instructions didn't mention it. PR-URL: #40669 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 31, 2022
Clean install requires pip to make coverage but instructions didn't mention it. PR-URL: #40669 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Linkgoron
pushed a commit
to Linkgoron/node
that referenced
this pull request
Jan 31, 2022
Clean install requires pip to make coverage but instructions didn't mention it. PR-URL: nodejs#40669 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Feb 1, 2022
Clean install requires pip to make coverage but instructions didn't mention it. PR-URL: #40669 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.