doc: simplify "make use of" to "use"#34861
Merged
Trott merged 2 commits intonodejs:masterfrom Aug 28, 2020
Merged
Conversation
Collaborator
|
Review requested:
|
jschlight
reviewed
Aug 21, 2020
Member
Author
|
@nodejs/documentation This could use some reviews. |
jasnell
reviewed
Aug 24, 2020
jasnell
approved these changes
Aug 24, 2020
trivikr
approved these changes
Aug 25, 2020
aymen94
approved these changes
Aug 25, 2020
doc/api/addons.md
Outdated
Contributor
There was a problem hiding this comment.
Suggested change
| examples use the V8 APIs. Refer to the online [V8 reference][v8-docs] | |
| examples utilize the V8 APIs. Refer to the online [V8 reference][v8-docs] |
Member
Author
There was a problem hiding this comment.
What's the reasoning for this suggestion?
Contributor
There was a problem hiding this comment.
They make use of them as a utility, no? (They find utility out of them.) Not blocking, just a thought. :)
PR-URL: nodejs#34861 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
PR-URL: nodejs#34861 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Member
Author
|
Landed in f461a66...496c174 |
richardlau
pushed a commit
that referenced
this pull request
Sep 1, 2020
PR-URL: #34861 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
PR-URL: #34861 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
PR-URL: #34861 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes