quic: refactor QuicSession stats and use net.BlockList#34741
Closed
jasnell wants to merge 6 commits into
Closed
Conversation
nodejs-github-bot
added
the
lib / src
Collaborator
|
Review requested:
|
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
request-ci
This comment has been minimized.
This comment has been minimized.
Collaborator
addaleax
approved these changes
Aug 11, 2020
koliberek0302
approved these changes
Aug 12, 2020
koliberek0302
approved these changes
Aug 12, 2020
Collaborator
jasnell
force-pushed
the
quic-cleanups-14
branch
from
ce1bccf to
19fe8b2
Compare
jasnell
added
author ready
4 tasks
This was referenced Aug 13, 2020
Trott
reviewed
Aug 14, 2020
Trott
approved these changes
Aug 14, 2020
This was referenced Aug 15, 2020
jasnell
force-pushed
the
quic-cleanups-14
branch
from
19fe8b2 to
c6d5078
Compare
Using a static label is sufficient.
Initial PR had it so that user code would create BlockList instances. This sets it up so that instances can be created internally by Node.js
jasnell
force-pushed
the
quic-cleanups-14
branch
from
c6d5078 to
40e2ca3
Compare
Member
Author
|
Landed in c17eaa3...c855c3e |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This depends on #34655 and #34669, both of which must land first. The first 6 commits here are from those earlier PRs.
There are several commits here:
These first three are minor and resolve several outstanding TODO items
Simplifies some of the stats collection
Enables use of the new
net.BlockListfor both client and server side.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes