tools: update remark-preset-lint-node@1.15.1 to 1.16.0#33852
Merged
Trott merged 0 commit intonodejs:masterfrom Jun 18, 2020
Merged
tools: update remark-preset-lint-node@1.15.1 to 1.16.0#33852Trott merged 0 commit intonodejs:masterfrom
Trott merged 0 commit intonodejs:masterfrom
Conversation
targos
approved these changes
Jun 12, 2020
Trott
added
the
author ready
Member
Author
|
@nodejs/linting |
watilde
approved these changes
Jun 17, 2020
nschonni
reviewed
Jun 17, 2020
tools/lint-md.js
Outdated
Member
There was a problem hiding this comment.
Bunch of diffs that look like they just add back in whitespace. Might be worth re-trimming
Member
Author
There was a problem hiding this comment.
It gets auto-trimmed on landing. rollup leaves the space. I'm reluctant to add post-processing to the rollup output. I always look at the diffs for these with whitespace turned off.
Trott
force-pushed
the
md-lint-preset-1.16.0
branch
2 times, most recently
from
03fe338 to
0717f36
Compare
Member
Author
|
Oh, look at that: A |
Contributor
That was a big fear of mine — should've fast-tracked in hindsight. Hopefully there's no issue w/ landing this puppy! |
Trott
added a commit
that referenced
this pull request
Jun 18, 2020
Use `bash` instead of `shell` for code language flag in doc/guides/maintaining-ngtcp2-nghttp3.md to conform with our other docs and upcoming lint requirements. PR-URL: #33852 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Trott
force-pushed
the
md-lint-preset-1.16.0
branch
from
0717f36 to
0ef6956
Compare
Member
Author
|
Landed in a4f3206...0ef6956 |
codebytere
pushed a commit
that referenced
this pull request
Jun 18, 2020
This adds linting for code fence language/grammar strings. This is so, for example, we have only one of ```text and ```txt and not both. PR-URL: #33852 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jun 30, 2020
This adds linting for code fence language/grammar strings. This is so, for example, we have only one of ```text and ```txt and not both. PR-URL: #33852 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
codebytere
pushed a commit
that referenced
this pull request
Jul 10, 2020
This adds linting for code fence language/grammar strings. This is so, for example, we have only one of ```text and ```txt and not both. PR-URL: #33852 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
codebytere
pushed a commit
that referenced
this pull request
Jul 12, 2020
This adds linting for code fence language/grammar strings. This is so, for example, we have only one of ```text and ```txt and not both. PR-URL: #33852 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
codebytere
pushed a commit
that referenced
this pull request
Jul 12, 2020
Use `bash` instead of `shell` for code language flag in doc/guides/maintaining-ngtcp2-nghttp3.md to conform with our other docs and upcoming lint requirements. PR-URL: #33852 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Merged
Contributor
|
Added the backported-to-v14.x label. Manually skipped landing 7407fc2 to v14.x as the file it changes doesn't exist on that branch |
codebytere
pushed a commit
that referenced
this pull request
Jul 14, 2020
This adds linting for code fence language/grammar strings. This is so, for example, we have only one of ```text and ```txt and not both. PR-URL: #33852 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
codebytere
pushed a commit
that referenced
this pull request
Jul 14, 2020
Use `bash` instead of `shell` for code language flag in doc/guides/maintaining-ngtcp2-nghttp3.md to conform with our other docs and upcoming lint requirements. PR-URL: #33852 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds linting for code fence language/grammar strings. This is so,
for example, we have only one of
text andtxt and not both.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes