dns: use ternary operator simplify statement#33234
Closed
zhangwinning wants to merge 1 commit intonodejs:masterfrom
Closed
dns: use ternary operator simplify statement#33234zhangwinning wants to merge 1 commit intonodejs:masterfrom
zhangwinning wants to merge 1 commit intonodejs:masterfrom
Conversation
tniessen
approved these changes
May 4, 2020
Member
tniessen
left a comment
tniessen
left a comment
There was a problem hiding this comment.
I am +0 on this. It doesn't really simplify much, the complexity of the if ... else ... is still there. It just saves additional call statements, while making things less readable.
Member
|
@zhangwinning Thank you for your contribution! I did not mean that this should not be merged. Do you want this to be reopened? |
Contributor
Author
|
@tniessen, I misunderstood you 😭, sorry for replying now, thank you guidance！ |
BridgeAR
approved these changes
May 23, 2020
Collaborator
BridgeAR
added
the
author ready
Collaborator
|
CI: https://ci.nodejs.org/job/node-test-pull-request/31518/ 💛 (a different flake then the one before) |
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
May 23, 2020
PR-URL: nodejs#33234 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Member
|
Landed in 5d06a37 @zhangwinning congratulations on your first commit to Node.js! 🎉 |
codebytere
pushed a commit
that referenced
this pull request
Jun 18, 2020
PR-URL: #33234 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jun 30, 2020
PR-URL: #33234 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
codebytere
pushed a commit
that referenced
this pull request
Jul 8, 2020
PR-URL: #33234 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes