Skip to content

test: update c8 ignore comment#33151

Closed
bcoe wants to merge 1 commit into
nodejs:masterfrom
bcoe:fix-ignore-logic
Closed

test: update c8 ignore comment#33151
bcoe wants to merge 1 commit into
nodejs:masterfrom
bcoe:fix-ignore-logic

Conversation

@bcoe

@bcoe bcoe commented Apr 30, 2020

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@bcoe bcoe requested a review from Trott April 30, 2020 00:01
@nodejs-github-bot nodejs-github-bot added the util Issues and PRs related to the built-in util module. label Apr 30, 2020
@bcoe bcoe added the test Issues and PRs related to the tests. label Apr 30, 2020
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@bcoe

bcoe commented May 1, 2020

Copy link
Copy Markdown
Contributor Author

@nodejs/testing bother someone for a 👍

@bcoe bcoe added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 1, 2020
@Trott

Trott commented May 4, 2020

Copy link
Copy Markdown
Member

Landed in bde5f9b

@Trott Trott closed this May 4, 2020
Trott pushed a commit that referenced this pull request May 4, 2020
PR-URL: #33151
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos pushed a commit that referenced this pull request May 4, 2020
PR-URL: #33151
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@targos targos mentioned this pull request May 4, 2020
targos pushed a commit that referenced this pull request May 7, 2020
PR-URL: #33151
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos pushed a commit that referenced this pull request May 7, 2020
PR-URL: #33151
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos pushed a commit that referenced this pull request May 13, 2020
PR-URL: #33151
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests. util Issues and PRs related to the built-in util module.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants