src: remove unnecessary fully qualified names#33077
Closed
rickyes wants to merge 1 commit intonodejs:masterfrom
Closed
src: remove unnecessary fully qualified names#33077rickyes wants to merge 1 commit intonodejs:masterfrom
rickyes wants to merge 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
the
c++
himself65
approved these changes
Apr 26, 2020
cjihrig
approved these changes
Apr 26, 2020
Contributor
cjihrig
left a comment
cjihrig
left a comment
There was a problem hiding this comment.
Code LGTM, but could you update the commit message. Maybe something alone the lines of src: remove unnecessary fully qualified names
rickyes
changed the title
rickyes
force-pushed
the
use-using-Local-and-Object
branch
from
1312437 to
90169a7
Compare
gireeshpunathil
approved these changes
Apr 27, 2020
Collaborator
|
CI: https://ci.nodejs.org/job/node-test-pull-request/31006/ (:heavy_check_mark:) |
jasnell
approved these changes
Apr 27, 2020
addaleax
added
the
author ready
Member
|
Landed in 37a5514 |
addaleax
pushed a commit
that referenced
this pull request
Apr 29, 2020
PR-URL: #33077 Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 4, 2020
PR-URL: #33077 Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 7, 2020
PR-URL: #33077 Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 13, 2020
PR-URL: #33077 Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes