build: log detected compilers in --verbose mode#32715
Closed
richardlau wants to merge 1 commit intonodejs:masterfrom
Closed
build: log detected compilers in --verbose mode#32715richardlau wants to merge 1 commit intonodejs:masterfrom
richardlau wants to merge 1 commit intonodejs:masterfrom
Conversation
Log the versions of the detected compilers when the configure script is run with `--verbose` to help verify which compiler is being used if multiple toolchains are installed on the system. Signed-off-by: Richard Lau <riclau@uk.ibm.com>
nodejs-github-bot
added
the
build
38 tasks
This comment has been minimized.
This comment has been minimized.
gireeshpunathil
approved these changes
Apr 8, 2020
richardlau
added
the
author ready
rvagg
approved these changes
Apr 8, 2020
Member
rvagg
left a comment
rvagg
left a comment
There was a problem hiding this comment.
nice, I thought we had this printing out by default long ago, maybe prior to prittification
This comment has been minimized.
This comment has been minimized.
Collaborator
sam-github
approved these changes
Apr 8, 2020
Contributor
|
I request this be fast-tracked, its low impact, and will really help in compiler level audit for 14.x I think if @riclau and one other person thumbs this comment up, I can land it. |
Member
Author
If you meant me I don't think I'd count towards fast tracking as the PR author, but you do and any other collaborator thumbing up your comment would count. |
addaleax
approved these changes
Apr 9, 2020
Contributor
|
Actually, you do count! And even better, as the author, you are implicitly assumed to agree to fast-tracking :-)
So, you could thumbsup, but you don't have to, mine is enough. I'm landing this. |
Contributor
|
Landed in 7251e8c |
sam-github
pushed a commit
that referenced
this pull request
Apr 9, 2020
Log the versions of the detected compilers when the configure script is run with `--verbose` to help verify which compiler is being used if multiple toolchains are installed on the system. Signed-off-by: Richard Lau <riclau@uk.ibm.com> PR-URL: #32715 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos
pushed a commit
that referenced
this pull request
Apr 12, 2020
Log the versions of the detected compilers when the configure script is run with `--verbose` to help verify which compiler is being used if multiple toolchains are installed on the system. Signed-off-by: Richard Lau <riclau@uk.ibm.com> PR-URL: #32715 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
sam-github
pushed a commit
to sam-github/node
that referenced
this pull request
Apr 13, 2020
Log the versions of the detected compilers when the configure script is run with `--verbose` to help verify which compiler is being used if multiple toolchains are installed on the system. Signed-off-by: Richard Lau <riclau@uk.ibm.com> PR-URL: nodejs#32715 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
4 tasks
Contributor
|
backport to v10.x: #32820 12.x picks clean It would be useful to have this in LTS for ease of verifying compiler levels. |
BethGriggs
pushed a commit
that referenced
this pull request
Apr 14, 2020
Log the versions of the detected compilers when the configure script is run with `--verbose` to help verify which compiler is being used if multiple toolchains are installed on the system. Signed-off-by: Richard Lau <riclau@uk.ibm.com> PR-URL: #32715 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos
pushed a commit
that referenced
this pull request
Apr 22, 2020
Log the versions of the detected compilers when the configure script is run with `--verbose` to help verify which compiler is being used if multiple toolchains are installed on the system. Signed-off-by: Richard Lau <riclau@uk.ibm.com> PR-URL: #32715 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
richardlau
added a commit
that referenced
this pull request
Jul 1, 2020
Log the versions of the detected compilers when the configure script is run with `--verbose` to help verify which compiler is being used if multiple toolchains are installed on the system. Signed-off-by: Richard Lau <riclau@uk.ibm.com> PR-URL: #32715 Backport-PR-URL: #32820 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Log the versions of the detected compilers when the configure script
is run with
--verboseto help verify which compiler is being used ifmultiple toolchains are installed on the system.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes