test: check inspector command Debugger.setInstrumentationBreakpoint by ulitink · Pull Request #31137 · nodejs/node

ulitink · 2019-12-30T13:01:58Z

Adds test case for inspector's method Debugger.setInstrumentationBreakpoint with beforeScriptExecution param.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
commit message follows commit guidelines

BridgeAR · 2020-01-04T11:22:31Z

@ulitink is this ready to review? Or is this still work in progress?

ulitink · 2020-01-05T16:22:17Z

@BridgeAR It is a test for an issue #31138. We can't merge this pull request until the issue is fixed because the test is broken. Sorry if such workflow is bad, we can simply reject the pull request and wait for the issue to be fixed, test is still referenced from it and can be found.

BridgeAR · 2020-01-06T21:02:57Z

It is possible to add this test and mark it as failing in our status file. That way it would only fail in case this test passes. If I understood correct, this test is legit and it should pass while it fails at the moment. That way it's possible to just remove the test from our status file while fixing the issue.

Trott · 2020-01-06T23:16:44Z

It is possible to add this test and mark it as failing in our status file. That way it would only fail in case this test passes. If I understood correct, this test is legit and it should pass while it fails at the moment. That way it's possible to just remove the test from our status file while fixing the issue.

If the test fails 100% of the time, probably best to put it in known_issues and then we can move it out to parallel (or wherever) when the fix is committed.

BridgeAR

RSLGTM

nodejs-github-bot · 2020-01-11T23:37:36Z

CI: https://ci.nodejs.org/job/node-test-pull-request/28379/

nodejs-github-bot · 2020-01-12T14:48:50Z

CI: https://ci.nodejs.org/job/node-test-pull-request/28406/

test/fixtures/inspector-instrumentation-breakpoint/main.js

Trott · 2020-01-14T05:38:17Z

@nodejs/inspector

test/known_issues/test-inspector-instrumentation-breakpoint.js

gireeshpunathil · 2020-11-05T12:20:37Z

Is this ready to land?

nodejs-github-bot · 2020-11-08T17:31:41Z

CI: https://ci.nodejs.org/job/node-test-pull-request/34211/

nodejs-github-bot · 2023-09-18T08:52:18Z

CI: https://ci.nodejs.org/job/node-test-pull-request/54029/

nodejs-github-bot · 2023-10-15T10:54:42Z

CI: https://ci.nodejs.org/job/node-test-pull-request/54810/

nodejs-github-bot · 2023-11-11T12:12:13Z

CI: https://ci.nodejs.org/job/node-test-pull-request/55557/

larson-carter · 2024-04-17T02:44:16Z

This is a quite old PR, I see it ties into #31138 is there any updates?

nodejs-github-bot · 2024-05-03T12:06:17Z

CI: https://ci.nodejs.org/job/node-test-pull-request/58895/

nodejs-github-bot · 2024-05-10T17:35:32Z

CI: https://ci.nodejs.org/job/node-test-pull-request/59079/

aduh95 · 2024-05-11T08:02:43Z

test/known_issues/test-inspector-instrumentation-breakpoint.js

+'use strict';
+const common = require('../common');
+
+common.skipIfInspectorDisabled();


It looks like skipping makes the test succeeds, which is considered a failure for known_issues/ tests..

nodejs-github-bot · 2024-05-11T08:49:18Z

CI: https://ci.nodejs.org/job/node-test-pull-request/59088/

nodejs-github-bot · 2024-05-12T07:14:34Z

CI: https://ci.nodejs.org/job/node-test-pull-request/59141/

nodejs-github-bot · 2024-05-12T17:22:20Z

CI: https://ci.nodejs.org/job/node-test-pull-request/59175/

nodejs-github-bot · 2024-05-12T19:22:11Z

CI: https://ci.nodejs.org/job/node-test-pull-request/59188/

aduh95 · 2024-05-12T20:33:09Z

Landed in 291c121

PR-URL: #31137 Refs: #31138 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

PR-URL: nodejs#31137 Refs: nodejs#31138 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 30, 2019

ulitink mentioned this pull request Dec 30, 2019

Debugger.setInstrumentationBreakpoint is broken #31138

Open

addaleax added the inspector Issues and PRs related to the V8 inspector protocol label Dec 30, 2019

ulitink marked this pull request as ready for review January 11, 2020 03:05

BridgeAR approved these changes Jan 11, 2020

View reviewed changes

Trott reviewed Jan 14, 2020

View reviewed changes

test/fixtures/inspector-instrumentation-breakpoint/main.js Outdated Show resolved Hide resolved

Trott approved these changes Jan 14, 2020

View reviewed changes

Trott reviewed Jan 14, 2020

View reviewed changes

test/known_issues/test-inspector-instrumentation-breakpoint.js Show resolved Hide resolved

BridgeAR force-pushed the master branch 2 times, most recently from 8ae28ff to 2935f72 Compare May 31, 2020 12:19

gireeshpunathil added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 5, 2020

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 5, 2020

This comment has been minimized.

Sign in to view

guybedford force-pushed the master branch from dc5a5da to 8e46568 Compare March 29, 2021 21:33

Trott force-pushed the main branch from 2d76238 to ca3ed36 Compare November 12, 2022 01:49

aduh95 closed this Sep 18, 2023

aduh95 reopened this Sep 18, 2023

aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Sep 18, 2023

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 18, 2023

github-actions bot mentioned this pull request Oct 10, 2023

CI Reliability 2023-10-10 nodejs/reliability#689

Open

24 tasks

aduh95 force-pushed the inspector-instrumentation-breakpoint branch from ec2b8e9 to c6d069d Compare October 23, 2023 18:21

jasnell approved these changes May 4, 2024

View reviewed changes

aduh95 reviewed May 11, 2024

View reviewed changes

ulitink and others added 6 commits May 11, 2024 10:09

test: add Debugger.setInstrumentationBreakpoint known issue

5286379

test: mute test-inspector-instrumentation-breakpoint

6a74aa6

test: fix formatting in test-inspector-instrumentation-breakpoint

38aa857

test: add description, fix linters

833be9c

lint

9c8a452

better skip

29607a1

aduh95 force-pushed the inspector-instrumentation-breakpoint branch from c6d069d to 29607a1 Compare May 11, 2024 08:42

aduh95 merged commit 291c121 into nodejs:main May 12, 2024

targos mentioned this pull request May 13, 2024

v22.2.0 release proposal #52971

Merged

marco-ippolito mentioned this pull request Jun 17, 2024

v20.15.0 proposal #53486

Merged

Uh oh!

Conversation

ulitink commented Dec 30, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

BridgeAR commented Jan 4, 2020

Uh oh!

ulitink commented Jan 5, 2020

Uh oh!

BridgeAR commented Jan 6, 2020

Uh oh!

Trott commented Jan 6, 2020

Uh oh!

BridgeAR left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Jan 11, 2020

Uh oh!

nodejs-github-bot commented Jan 12, 2020

Uh oh!

Uh oh!

Trott commented Jan 14, 2020

Uh oh!

Uh oh!

gireeshpunathil commented Nov 5, 2020

Uh oh!

This comment has been minimized.

nodejs-github-bot commented Nov 8, 2020

Uh oh!

nodejs-github-bot commented Sep 18, 2023

Uh oh!

nodejs-github-bot commented Oct 15, 2023

Uh oh!

nodejs-github-bot commented Nov 11, 2023

Uh oh!

larson-carter commented Apr 17, 2024

Uh oh!

nodejs-github-bot commented May 3, 2024

Uh oh!

nodejs-github-bot commented May 10, 2024

Uh oh!

aduh95 May 11, 2024

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented May 11, 2024

Uh oh!

nodejs-github-bot commented May 12, 2024

Uh oh!

nodejs-github-bot commented May 12, 2024

Uh oh!

nodejs-github-bot commented May 12, 2024

Uh oh!

aduh95 commented May 12, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

ulitink commented Dec 30, 2019 •

edited

Loading