Skip to content

perf_hooks: change var to let #30387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jasnell wants to merge 1 commit into from
Closed

perf_hooks: change var to let #30387

jasnell wants to merge 1 commit into from

Conversation

@jasnell
Copy link
Member

@jasnell jasnell commented Nov 12, 2019

Code and Learn walkthrough... change var to let

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the perf_hooks Issues and PRs related to the implementation of the Performance Timing API. label Nov 12, 2019
@jasnell jasnell added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 12, 2019
@BridgeAR
Copy link
Member

BridgeAR commented Nov 13, 2019

Lite CI https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4047/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 13, 2019
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 16, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/26607/

@gireeshpunathil
Copy link
Member

gireeshpunathil commented Nov 26, 2019

@jasnell - could you pls rebase?

@addaleax addaleax removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 29, 2019
@BridgeAR
Copy link
Member

BridgeAR commented Dec 25, 2019

Ping @jasnell

@BridgeAR
Copy link
Member

BridgeAR commented Jan 2, 2020

Closing in favor of #31049 (@jasnell you did give a LG, so I expect that's alright. Please reopen and rebase otherwise).

@BridgeAR BridgeAR closed this Jan 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@trivikr trivikr trivikr approved these changes

Assignees

No one assigned

Labels

code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. perf_hooks Issues and PRs related to the implementation of the Performance Timing API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@jasnell @BridgeAR @nodejs-github-bot @gireeshpunathil @Trott @lpinca @cjihrig @trivikr @addaleax