Merged
Conversation
devsnek
added
confirmed-bug
nodejs-github-bot
added
c++
devsnek
added
build
Member
|
node v12.5 - v12.10 all mistakenly have this method; i hope this is considered a patch, though, and not a major :-/ |
jasnell
approved these changes
Sep 16, 2019
Member
jasnell
left a comment
jasnell
left a comment
There was a problem hiding this comment.
I think we can consider this a patch / bug fix
devsnek
force-pushed
the
fix/atomics-wake-deleted
branch
from
cb69c64 to
0c73abd
Compare
Collaborator
addaleax
approved these changes
Sep 16, 2019
Member
addaleax
left a comment
addaleax
left a comment
There was a problem hiding this comment.
LGTM if @joyeecheung is good with this, although I’m surprised that snapshots don’t also include the state of builtins…
Member
Author
|
@addaleax any flagged features will not be included in snapshots, even if they're enabled by default, because they could be disabled at runtime by using In this case |
joyeecheung
approved these changes
Sep 17, 2019
src/api/environment.cc
Outdated
Member
There was a problem hiding this comment.
It looks more reasonable to do this later than InitializeContext() here since logically InitializeContext is supposed to give you a context that looks like the one created with Context::FromSnapshot
cjihrig
approved these changes
Sep 17, 2019
devsnek
force-pushed
the
fix/atomics-wake-deleted
branch
from
0c73abd to
12c21fc
Compare
Collaborator
devnexen
approved these changes
Sep 17, 2019
devsnek
added
the
author ready
Contributor
|
Needs a rebase. |
devsnek
force-pushed
the
fix/atomics-wake-deleted
branch
from
12c21fc to
32a1656
Compare
PR-URL: nodejs#29586 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>
devsnek
force-pushed
the
fix/atomics-wake-deleted
branch
from
32a1656 to
1ec4154
Compare
Member
Author
|
landed in 1ec4154 |
devsnek
removed
the
author ready
targos
pushed a commit
that referenced
this pull request
Sep 20, 2019
PR-URL: #29586 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>
Merged
BridgeAR
pushed a commit
that referenced
this pull request
Sep 25, 2019
PR-URL: #29586 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>
This was referenced Sep 25, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deletion logic was running at snapshot time, and snapshots don't have
global.Atomics, so this just stopped deletingAtomics.wake. This is fixed by creating a new C++ helper that is called after bothContext::NewandContext::FromSnapshot.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes