build: ease DragonFlyBSD build#29284
Closed
devnexen wants to merge 2 commits intonodejs:masterfrom
devnexen:dfbsd_build_chg
Closed
build: ease DragonFlyBSD build#29284devnexen wants to merge 2 commits intonodejs:masterfrom devnexen:dfbsd_build_chg
devnexen wants to merge 2 commits intonodejs:masterfrom
devnexen:dfbsd_build_chg
Conversation
nodejs-github-bot
added
c++
devnexen
changed the title
Implicitly pretending being FreeBSD and disable large pages for this platform.
bnoordhuis
approved these changes
Aug 25, 2019
Member
bnoordhuis
left a comment
bnoordhuis
left a comment
There was a problem hiding this comment.
LGTM with a suggestion. Can you break out the change to tools/gyp/pylib/gyp/common.py into its own commit? That makes gyp upgrades a little easier.
(Not that I expect that there will be many but still.)
src/large_pages/node_large_page.cc
Outdated
|
|
||
| #if defined(__DragonFly__) | ||
| #error "Large pages is not supported by this platform" | ||
| #endif |
Member
There was a problem hiding this comment.
It would be nicer to error out in configure.py rather than defer until build time. It should preferably also be its own separate commit.
Contributor
Author
There was a problem hiding this comment.
That comes more from the fact dragonflybsd "is" FreeBSD from configure standpoint.
addaleax
approved these changes
Aug 25, 2019
Collaborator
Member
|
@devnexen ping. Should we merge or close this? |
Contributor
Author
|
Can be merged if good as is |
Collaborator
fhinkel
approved these changes
Nov 1, 2019
Member
|
@devnexen Can you squash your commits and rebase please. Thanks |
Contributor
Author
|
AS I lost the original fork here it is #30201 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implicitly pretending being FreeBSD and disable
large pages for this platform.