Revert "stream: do not emit drain if stream ended" #29272
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 605d7c4.
nodejs-github-bot
added
the
stream
Collaborator
Member
Author
|
cc @isaacs |
cjihrig
approved these changes
Aug 22, 2019
Fishrock123
approved these changes
Aug 22, 2019
jasnell
approved these changes
Aug 22, 2019
Contributor
|
Digging into this further based on feedback from @ronag. Might have an update in an hour or two. |
Contributor
Contributor
Member
Author
|
Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 605d7c4 following up from the discussion in #29086 (comment).
Please 👍 for fast-track.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passescommit message follows commit guidelines