test: remove duplicate test-child-process-execfilesync-maxBuffer.js#28139
Closed
joyeecheung wants to merge 1 commit intonodejs:masterfrom
Closed
test: remove duplicate test-child-process-execfilesync-maxBuffer.js#28139joyeecheung wants to merge 1 commit intonodejs:masterfrom
joyeecheung wants to merge 1 commit intonodejs:masterfrom
Conversation
In addition correct the comment about what it does.
Collaborator
|
Sadly, an error occurred when I tried to trigger a build. :( |
Collaborator
ZYSzys
approved these changes
Jun 9, 2019
4 tasks
Member
|
Micro-nit: Is |
addaleax
approved these changes
Jun 9, 2019
addaleax
added
the
author ready
lpinca
approved these changes
Jun 9, 2019
Member
Author
|
@Trott There is also |
Trott
approved these changes
Jun 10, 2019
cjihrig
approved these changes
Jun 10, 2019
pull bot
pushed a commit
to whtiehack/node
that referenced
this pull request
Jun 12, 2019
In addition correct the comment about what it does. PR-URL: nodejs#28139 Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Member
Author
|
Landed in e0fa30f |
BridgeAR
pushed a commit
that referenced
this pull request
Jun 17, 2019
In addition correct the comment about what it does. PR-URL: #28139 Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In addition correct the comment about what it does.
This is produced by
If you use https://github.com/nodejs/node/pull/28139/files?w=1 to view the diff you can see they aren't doing anything too different.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes