[x] stream: add bytesRead to Readable #27988
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
stream
mscdex
reviewed
May 30, 2019
ronag
force-pushed
the
feat-stream-readCount
branch
from
cb19bd2 to
e82d510
Compare
addaleax
reviewed
May 30, 2019
Member
addaleax
left a comment
addaleax
left a comment
There was a problem hiding this comment.
Some notes:
- In other places in core (e.g.
net.Socket), we track the same thing and call itbytesRead(although I think it may vary in case of.setEncoding()being used) - For Writables, there’s
bytesWrittenin that case, which might also be interesting if we do want this at the streams level
addaleax
added
the
semver-minor
ronag
force-pushed
the
feat-stream-readCount
branch
2 times, most recently
from
675cb94 to
ae8b600
Compare
Contributor
|
Also, tests should be added for this. |
Member
Author
|
Member
|
I agree with @addaleax that |
Member
Author
|
Updated |
ronag
force-pushed
the
feat-stream-readCount
branch
from
ae8b600 to
86dacd2
Compare
ronag
changed the title
Member
|
cc @nodejs/streams |
mcollina
requested changes
Jun 10, 2019
Member
mcollina
left a comment
mcollina
left a comment
There was a problem hiding this comment.
Tests are needed.
Overall I would prefer a generic API that works with both object mode and non-object mode streams.
ronag
force-pushed
the
feat-stream-readCount
branch
from
86dacd2 to
049315f
Compare
Member
Author
|
@mcollina sorry for delay, how about now? |
mscdex
reviewed
Jul 13, 2019
mscdex
reviewed
Jul 13, 2019
mcollina
requested changes
Jul 14, 2019
Member
mcollina
left a comment
mcollina
left a comment
There was a problem hiding this comment.
Can you add bytesWritten as well for simmetry?
ronag
force-pushed
the
feat-stream-readCount
branch
from
f55d84b to
a39ffd1
Compare
Member
Author
|
@mcollina done |
Member
|
Ping @ronag ... this PR needs tests in order to proceed. |
Member
Author
|
This is blocked by #28004. In regards to some questions about naming and |
Member
Author
|
I'm closing this for now. |
ronag
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a somewhat common scenario to be able to keep track of number of bytes that has been read from a stream. The only way to achieve this in user land will cause either complexity or performance overhead.
Adding it into core would be somewhat untrivial both in terms of complexity and performance.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes