Conversation
ZYSzys
added
doc
|
Potentially-unpopular opinion: All of this text can be deleted. It lists the reasons any platform might deprecate an API. Nothing in there is specific or peculiar to Node.js. And it's not clear that it's a comprehensive list. We don't need to list why we deprecate when those reasons are the same as every other platform. We can go right into the different kinds of deprecations. |
|
One potential problem with this change: The current wording (mostly) makes it clear that any one of the three possibilities is enough to deprecate. This new format might lead one to think that all three things must be true. (Another argument for just deleting it!) |
|
Lastly: All my comments here are non-blocking. There's always going to be room for improvement. Docs! Amirite? |
trivikr
added
the
author ready
Co-Authored-By: Rich Trott <rtrott@gmail.com>
Co-Authored-By: Rich Trott <rtrott@gmail.com>
Co-Authored-By: Rich Trott <rtrott@gmail.com>
Co-Authored-By: Rich Trott <rtrott@gmail.com>
trivikr
force-pushed
the
deprecation-reasons
branch
from
00abf78 to
dd75200
Compare
Trott
left a comment
Trott
left a comment
There was a problem hiding this comment.
LGTM with or without my remaining suggestion applied
|
Landed in 5c61c5d |
PR-URL: nodejs#27960 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
PR-URL: #27960 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
3 participants
Checklist