test: fix arguments order of comparsion functions #27907
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChALkeR
approved these changes
May 26, 2019
BridgeAR
approved these changes
May 26, 2019
BridgeAR
added
the
code-and-learn
cjihrig
approved these changes
May 26, 2019
Trott
approved these changes
May 27, 2019
Trott
added
the
author ready
Collaborator
gireeshpunathil
approved these changes
May 27, 2019
Collaborator
Collaborator
Member
|
Please react with 👍for fast-tracking. |
Place actual values as the first agruments and expected as the second. PR-URL: nodejs#27907 Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
ChALkeR
force-pushed
the
fix-arguments-order-in-comparsion-functions
branch
from
6ac4567 to
d6cc6ab
Compare
Member
|
Landed in d6cc6ab. Thanks for the contribution! 🎉 https://www.nodetodo.org/next-steps/ is a good list of ideas on possible next steps. (But the next steps are not limited to just that list -- you can always come up with your own)! |
targos
pushed a commit
that referenced
this pull request
May 28, 2019
Place actual values as the first agruments and expected as the second. PR-URL: #27907 Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Place actual values as the first arguments and expected as the second.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes