punycode: use strict identity operator #2644
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no type-conversion to be done because both parameters are already the same type. Therefore, the === operator should be used for better performance.
Contributor
Member
|
Also punycode is an external dependency. Changes to it should be proposed in the original project. |
Member
|
/cc @mathiasbynens - maybe you can pull this into punycode.js? There are some mild performance benefits associated with strict equality checks. |
Contributor
|
As @targos said, could you make this PR against https://github.com/bestiejs/punycode.js so we can discuss it there? I seriously doubt |
Member
Author
|
@mathiasbynens Sure, I will |
Member
|
Closing, discussion can continue on mathiasbynens/punycode.js#35. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no type-conversion to be done because both parameters are already the same type.
Therefore, the === operator should be used for better performance.