timers: support name in validateTimerDuration()#26215
Merged
cjihrig merged 1 commit intonodejs:masterfrom Feb 22, 2019
Merged
Conversation
nodejs-github-bot
added
http
addaleax
approved these changes
Feb 20, 2019
BridgeAR
approved these changes
Feb 20, 2019
lpinca
approved these changes
Feb 20, 2019
Contributor
Author
|
CI: https://ci.nodejs.org/job/node-test-pull-request/20914/ EDIT: CI was green. |
apapirovski
approved these changes
Feb 20, 2019
jasnell
approved these changes
Feb 21, 2019
BridgeAR
added
the
author ready
Allow passing a name to validateTimerDuration() so that error messages can reflect the name of the thing being validated. PR-URL: nodejs#26215 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: James M Snell <jasnell@gmail.com>
cjihrig
force-pushed
the
val-timer-dur
branch
from
c7ef19d to
a1d05e4
Compare
Member
|
Should this be backported to I assume it doesn’t really need to get backported because it’s preparation for a semver-major PR. Feel free to do so, though. |
This was referenced Apr 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As requested in #26214 (review)
Allow passing a name to
validateTimerDuration()so that error messages can reflect the name of the thing being validated.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes