[v8.x backport] doc: sort bottom-of-file markdown links#24682
Closed
sam-github wants to merge 2 commits intonodejs:v8.x-stagingfrom
Closed
[v8.x backport] doc: sort bottom-of-file markdown links#24682sam-github wants to merge 2 commits intonodejs:v8.x-stagingfrom
sam-github wants to merge 2 commits intonodejs:v8.x-stagingfrom
Conversation
Collaborator
|
@sam-github sadly an error occured when I tried to trigger a build :( |
sam-github
changed the title
4 tasks
Contributor
|
Does this need rebasing? |
sam-github
force-pushed
the
backport-24679-to-v8.x
branch
from
fa6e71a to
cdea42e
Compare
Contributor
Author
|
PTAL |
Contributor
|
Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
Contributor
Author
Contributor
Author
|
@nodejs/lts can you merge this to staging before it collects more conflicts? pls. |
Member
|
👍 done ffe1f80 |
Merged
This was referenced Dec 18, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #24679
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes