Skip to content

test: fix if-error-has-good-stack #18378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
joyeecheung wants to merge 1 commit into from
Closed

test: fix if-error-has-good-stack #18378

joyeecheung wants to merge 1 commit into from

Conversation

@joyeecheung
Copy link
Member

@joyeecheung joyeecheung commented Jan 25, 2018

Fixes: #18377

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jan 25, 2018
apapirovski
apapirovski approved these changes Jan 25, 2018
View reviewed changes
Copy link
Contributor

@apapirovski apapirovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@apapirovski apapirovski added the fast-track PRs that do not need to wait for 48 hours to land. label Jan 25, 2018
@joyeecheung
Copy link
Member Author

joyeecheung commented Jan 25, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/12734/

@joyeecheung joyeecheung mentioned this pull request Jan 25, 2018
Closed
@apapirovski apapirovski mentioned this pull request Jan 25, 2018
Closed
4 tasks
Trott
Trott approved these changes Jan 25, 2018
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BridgeAR
Copy link
Member

BridgeAR commented Jan 25, 2018

Sorry, seems like I missed that when checking the CI.

@joyeecheung
Copy link
Member Author

joyeecheung commented Jan 25, 2018

Infra issue on ubuntu1604-arm64_odroid_c2, stringbytes-external-exceed-max on some alpine containers, test-tls-server-verify on windows, all known flakes

@joyeecheung joyeecheung added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 25, 2018
joyeecheung added a commit that referenced this pull request Jan 25, 2018
@joyeecheung
test: fix if-error-has-good-stack
bea5f26 
PR-URL: #18378
Fixes: #18377
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@joyeecheung
Copy link
Member Author

joyeecheung commented Jan 25, 2018

Landed in bea5f26, thanks!

@joyeecheung joyeecheung removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 29, 2018
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@joyeecheung @MayaLekova
test: fix if-error-has-good-stack
25ef1a1 
PR-URL: nodejs#18378
Fixes: nodejs#18377
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes

@cjihrig cjihrig cjihrig approved these changes

@richardlau richardlau richardlau approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

+1 more reviewer

@apapirovski apapirovski apapirovski approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

test: if-error-has-good-stack is broken on windows

8 participants

@joyeecheung @BridgeAR @apapirovski @Trott @cjihrig @richardlau @MylesBorins @nodejs-github-bot