Skip to content

Conversation

@WaleedAshraf
Copy link
Contributor

@WaleedAshraf WaleedAshraf commented Dec 20, 2017

Closes : #17618

Checklist
  • documentation is changed or added
Affected core subsystem(s)

doc

@nodejs-github-bot nodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to the documentations. labels Dec 20, 2017
@Trott
Copy link
Member

Trott commented Dec 20, 2017

Hello, @WaleedAshraf and thanks for the contribution! I don't think this is an improvement, to be honest. If we specify that something is the default, then it should be expected that the default will be used if the value is undefined. I'd prefer we avoid such "sky is blue unless otherwise noted" explanations and instead remove the text about it being "ignored" entirely. What do you think?

@WaleedAshraf
Copy link
Contributor Author

Agreed @Trott .
By just mentioning Default=someValue , It is clear that if user is not setting a value, it will be set to default.

@WaleedAshraf
Copy link
Contributor Author

WaleedAshraf commented Dec 20, 2017

Sorry, I forgot to follow guideline for pull request. (Should have rebased instead of merge commit). Let me create a new PR?

@WaleedAshraf
Copy link
Contributor Author

WaleedAshraf commented Dec 20, 2017

@Trott closed in-refer to: #17796

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants