Skip to content

Update test-http-response-status-message to use Countdown #17552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Leko wants to merge 1 commit into from
Closed

Update test-http-response-status-message to use Countdown #17552

Leko wants to merge 1 commit into from

Conversation

@Leko
Copy link
Contributor

@Leko Leko commented Dec 8, 2017

Use Countdown class instead of testsComplete in test-http-response-status-message.js.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 8, 2017
@Leko
Copy link
Contributor Author

Leko commented Dec 8, 2017

I closed this PR because dupe of #17326.

@Leko Leko closed this Dec 8, 2017
@Leko Leko deleted the use_countdown_in_http-response-status-message branch December 8, 2017 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Leko @nodejs-github-bot