test: mark big string tests flaky on freebsd #16358
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the addons/stringbytes-external-exceed-max tests are known flaky after the upgrade to V8 6.2. The most likely reason is the increase of the maximum string length from 256 to 1024 MB, pushing their execution times over the time limit. Fixes: nodejs#16354 Refs: nodejs#15362
nodejs-github-bot
added
addons
cjihrig
approved these changes
Oct 21, 2017
targos
approved these changes
Oct 21, 2017
jasnell
approved these changes
Oct 22, 2017
gibfahn
approved these changes
Oct 23, 2017
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the addons/stringbytes-external-exceed-max tests are known flaky
after the upgrade to V8 6.2. The most likely reason is the increase of
the maximum string length from 256 to 1024 MB, pushing their execution
times over the time limit.
Fixes: #16354
Refs: #15362
CI: https://ci.nodejs.org/job/node-test-pull-request/10887/