Skip to content

Conversation

@tniessen
Copy link
Member

PR-URL: #15472

@tniessen tniessen added the v6.x label Oct 19, 2017
@tniessen tniessen requested a review from silverwind October 19, 2017 10:38
@nodejs-github-bot nodejs-github-bot added dns Issues and PRs related to the dns subsystem. doc Issues and PRs related to the documentations. v6.x labels Oct 19, 2017
doc/api/dns.md Outdated
Copy link
Contributor

@silverwind silverwind Oct 19, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think resolveAny was backported to v6.x, so this line probably has to go.

PR-URL: nodejs#15472
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@tniessen tniessen force-pushed the backport-15472-to-v6.x branch from f245ee3 to 2192ed7 Compare October 20, 2017 09:13
@tniessen
Copy link
Member Author

@silverwind Thank you, fixed! PTAL

MylesBorins pushed a commit that referenced this pull request Oct 25, 2017
Backport-PR-URL: #16316
PR-URL: #15472
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorins
Copy link
Contributor

landed in 3293a0c

MylesBorins pushed a commit that referenced this pull request Oct 25, 2017
Backport-PR-URL: #16316
PR-URL: #15472
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 26, 2017
Backport-PR-URL: #16316
PR-URL: #15472
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dns Issues and PRs related to the dns subsystem. doc Issues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants