src: rename StreamWrap to LibuvStreamWrap#16157
Closed
addaleax wants to merge 1 commit intonodejs:masterfrom
Closed
src: rename StreamWrap to LibuvStreamWrap#16157addaleax wants to merge 1 commit intonodejs:masterfrom
addaleax wants to merge 1 commit intonodejs:masterfrom
Conversation
This should help clarify what kind of resource a `StreamWrap` represents.
nodejs-github-bot
added
c++
danbev
approved these changes
Oct 12, 2017
watilde
approved these changes
Oct 12, 2017
fhinkel
approved these changes
Oct 12, 2017
jasnell
approved these changes
Oct 12, 2017
Member
TimothyGu
approved these changes
Oct 12, 2017
joyeecheung
approved these changes
Oct 13, 2017
Member
|
CI failure is unrelated |
jasnell
pushed a commit
that referenced
this pull request
Oct 13, 2017
This should help clarify what kind of resource a `StreamWrap` represents. PR-URL: #16157 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Member
|
Landed in 00fe76d |
addaleax
added a commit
to ayojs/ayo
that referenced
this pull request
Oct 15, 2017
This should help clarify what kind of resource a `StreamWrap` represents. PR-URL: nodejs/node#16157 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
targos
pushed a commit
that referenced
this pull request
Oct 18, 2017
This should help clarify what kind of resource a `StreamWrap` represents. PR-URL: #16157 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Contributor
|
Should this be backported to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should help clarify what kind of resource a
StreamWraprepresents.Hopefully one of many PRs to come towards more accessible Node internals.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
src