Skip to content

url: const-ify first argument of ToUnicode function #15725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lpinca wants to merge 1 commit into from
Closed

url: const-ify first argument of ToUnicode function #15725

lpinca wants to merge 1 commit into from

Conversation

@lpinca
Copy link
Member

@lpinca lpinca commented Oct 2, 2017

Fixes a compiler error on Windows.

Refs: #15615 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

url

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. dont-land-on-v4.x whatwg-url Issues and PRs related to the WHATWG URL implementation. labels Oct 2, 2017
@lpinca
Copy link
Member Author

lpinca commented Oct 2, 2017

Closing in favor of #15724.

@lpinca lpinca closed this Oct 2, 2017
@lpinca lpinca deleted the constify/input-arg branch October 2, 2017 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. whatwg-url Issues and PRs related to the WHATWG URL implementation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lpinca @nodejs-github-bot