Http2 test coverage for ServerHttp2Stream.respondWithFD #15323
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Test that forbidden headers throw ERR_HTTP2_PAYLOAD_FORBIDDEN errors - Correct constant HTTP_STATUS_CONTENT_RESET to HTTP_STATUS_RESET_CONTENT in core.js Refs: nodejs#14985
ssbrewster
changed the title
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR increases test coverage in
ServerHttp2Stream.respondWithFDand correctsHTTP_STATUS_CONTENT_RESETtoHTTP_STATUS_RESET_CONTENTinlib/internal/http2/core.js.Once I've got feedback on this PR I can do something similar for
ServerHttp2Stream.respondWithFile(that I think should push the branch coverage forcore.jsinto the green).Refs: #14985
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
http2, test