Skip to content

doc: fix typo in writing-and-running-benchmarks.md#14600

Closed
hiroppy wants to merge 1 commit into
nodejs:masterfrom
hiroppy:feature/typo-benchmarks-doc
Closed

doc: fix typo in writing-and-running-benchmarks.md#14600
hiroppy wants to merge 1 commit into
nodejs:masterfrom
hiroppy:feature/typo-benchmarks-doc

Conversation

@hiroppy

@hiroppy hiroppy commented Aug 2, 2017

Copy link
Copy Markdown
Member
Checklist
Affected core subsystem(s)

doc

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Aug 2, 2017
@hiroppy hiroppy added the benchmark Issues and PRs related to the benchmark subsystem. label Aug 2, 2017

@Trott Trott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Trott

Trott commented Aug 2, 2017

Copy link
Copy Markdown
Member

Landed in 46c3dd7

@Trott Trott closed this Aug 2, 2017
Trott pushed a commit to Trott/io.js that referenced this pull request Aug 2, 2017
PR-URL: nodejs#14600
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@hiroppy hiroppy deleted the feature/typo-benchmarks-doc branch August 3, 2017 00:08
addaleax pushed a commit that referenced this pull request Aug 7, 2017
PR-URL: #14600
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

benchmark Issues and PRs related to the benchmark subsystem. doc Issues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants