deps: back-port b049d1a from V8 upstream #11204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
v8 engine
Member
Author
|
@nodejs/v8 I'm quietly hopeful this commit will fix some of the bug reports we've received about mksnapshot dying with SIGBUS on ARM and MIPS. |
ofrobots
approved these changes
Feb 8, 2017
Contributor
ofrobots
left a comment
ofrobots
left a comment
There was a problem hiding this comment.
LGTM. Can you request upstream backports to 5.6 and 5.7 as well?
Original commit message:
Ensure we align zone memory at 8 byte boundaries on all platforms
BUG=v8:5668
R=verwaest@chromium.org
Review-Url: https://codereview.chromium.org/2672203002
Cr-Commit-Position: refs/heads/master@{nodejs#42959}
PR-URL: nodejs#11204
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
bnoordhuis
force-pushed
the
v8-backport-b049d1a
branch
from
c6ea694 to
039a813
Compare
Member
Author
Done: https://bugs.chromium.org/p/v8/issues/detail?id=5668#c8 |
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Feb 9, 2017
Original commit message:
Ensure we align zone memory at 8 byte boundaries on all platforms
BUG=v8:5668
R=verwaest@chromium.org
Review-Url: https://codereview.chromium.org/2672203002
Cr-Commit-Position: refs/heads/master@{nodejs#42959}
PR-URL: nodejs#11204
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Feb 14, 2017
Original commit message:
Ensure we align zone memory at 8 byte boundaries on all platforms
BUG=v8:5668
R=verwaest@chromium.org
Review-Url: https://codereview.chromium.org/2672203002
Cr-Commit-Position: refs/heads/master@{nodejs#42959}
PR-URL: nodejs#11204
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
krydos
pushed a commit
to krydos/node
that referenced
this pull request
Feb 25, 2017
Original commit message:
Ensure we align zone memory at 8 byte boundaries on all platforms
BUG=v8:5668
R=verwaest@chromium.org
Review-Url: https://codereview.chromium.org/2672203002
Cr-Commit-Position: refs/heads/master@{nodejs#42959}
PR-URL: nodejs#11204
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Member
|
backport PRs would be needed to land this in v6 or v4 (if appropriate for either) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original commit message:
CI: https://ci.nodejs.org/job/node-test-pull-request/6245/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/557/