Skip to content

Request/Response.formData() throws ERR_ASSERTION on a multipart file part when globalThis.File is replaced #67516

Open
nodejs/undici
#6212

Description

@saadqbal

Version

v24.22.2 and v26.13.1. v22.23.3 is fine.

Platform

macOS (darwin arm64). Not platform-specific as far as I can tell.

Subsystem

fetch (bundled undici)

What steps will reproduce the bug?

plain.mjs, no dependencies:

const body =
  "--b\r\n" +
  'Content-Disposition: form-data; name="f"; filename="a.txt"\r\n' +
  "Content-Type: text/plain\r\n\r\n" +
  "hello\r\n" +
  "--b--\r\n";
const parse = () =>
  new Response(body, { headers: { "content-type": "multipart/form-data; boundary=b" } }).formData();

console.log((await parse()).get("f") instanceof File); // true

globalThis.File = class File extends Blob {
  constructor(bits, name, opts) { super(bits, opts); this.name = name; }
};
await parse(); // v24/v26: AssertionError [ERR_ASSERTION]
AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value:
  assert(typeof value === "string" && webidl.is.USVString(value) || webidl.is.File(value))
    at multipartFormDataParser (node:internal/deps/undici/undici:...)

How often does it reproduce?

Always.

What is the expected behavior?

formData() returns a FormData whose "f" entry is a file with the content hello, as on v22. It shouldn't depend on what the global File binding currently points to.

What do you see instead?

multipartFormDataParser creates the part with new File(...), which looks up the global File at call time. It then checks the result with webidl.is.File, which is MakeTypeAssertion(File) taken from Node's own File when the module loads. Once the global is replaced, the object it just created fails the check.

Additional information

This is what happens under DOM test environments: vitest and jest with jsdom install the DOM's File on globalThis. Any Request.formData() on a multipart body with a file part then fails, which includes every MSW request handler that reads an upload.

The vitest + jsdom project below reproduces it in that setting (npm i && npx vitest run): it passes on v22.23.3 and fails on v24.22.2 and v26.13.1.

vitest + jsdom reproduction

package.json

{
  "name": "undici-jsdom-formdata-repro",
  "private": true,
  "type": "module",
  "scripts": { "test": "vitest run" },
  "devDependencies": { "jsdom": "27.4.0", "vitest": "4.1.12" }
}

vitest.config.mjs

export default { test: { environment: "jsdom", execArgv: ["--no-experimental-webstorage"] } };

formdata.test.mjs

import { expect, test } from "vitest";

// Under jsdom, globalThis.File is jsdom's. Node's Request.formData() then fails on a file part.
test("Request.formData() parses a multipart file part under jsdom", async () => {
  const body =
    "--b\r\n" +
    'Content-Disposition: form-data; name="f"; filename="a.txt"\r\n' +
    "Content-Type: text/plain\r\n\r\n" +
    "hello\r\n" +
    "--b--\r\n";
  const req = new Request("http://example.invalid/", {
    method: "POST",
    headers: { "content-type": "multipart/form-data; boundary=b" },
    body,
  });
  const part = (await req.formData()).get("f");
  expect(await part.text()).toBe("hello");
});

A possible fix: construct the part with the same internal File the brand check uses, instead of the global binding.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions