It seems we have some ambiguity in docs.
https://github.com/nodejs/node/blob/master/COLLABORATOR_GUIDE.md#code-reviews:
All pull requests must be reviewed and accepted by a Collaborator with sufficient expertise who is able to take full responsibility for the change. In the case of pull requests proposed by an existing Collaborator, an additional Collaborator is required for sign-off.
https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#step-10-landing
In order to land, a Pull Request needs to be reviewed and approved by at least one Node.js Collaborator and pass a CI (Continuous Integration) test run.
Evidence of confusing:
#21318 (comment)
So how many approval do we need for a PR when the author is a Collaborator?
It seems we have some ambiguity in docs.
https://github.com/nodejs/node/blob/master/COLLABORATOR_GUIDE.md#code-reviews:
https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#step-10-landing
Evidence of confusing:
#21318 (comment)
So how many approval do we need for a PR when the author is a Collaborator?