Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 1f6fe2f3bd
Choose a base ref
...
head repository: nodejs/node
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: bd2b98f549
Choose a head ref
  • 19 commits
  • 134 files changed
  • 10 contributors

Commits on Sep 15, 2026

  1. tools: pass author to commit message validator

    Signed-off-by: Filip Skokan <panva.ip@gmail.com>
    PR-URL: #66012
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
    panva authored Sep 15, 2026
    Configuration menu
    Copy the full SHA
    3c050e3 View commit details
    Browse the repository at this point in the history
  2. tools: update nixpkgs-unstable to aff8a0b28396750446e5537a96461bc4fac

    PR-URL: #66010
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    nodejs-github-bot authored Sep 15, 2026
    Configuration menu
    Copy the full SHA
    fe10572 View commit details
    Browse the repository at this point in the history
  3. ffi: load libraries from a mounted VFS

    The operating system's dynamic loader cannot open a library that lives
    in a mounted virtual file system: the reserved mount path has no real
    inode. Native addons already handle this in require(): the loader
    hands their bytes to process.dlopen(), which loads them from a
    private, self-cleaning image - an anonymous in-memory memfd on Linux.
    
    Make ffi.dlopen() and new DynamicLibrary() do the same transparently.
    Mirroring the fs handler integration, the VFS hook installer sets a
    library reader into node:ffi while at least one VFS is mounted and
    clears it when the last one unmounts; DynamicLibrary consults it
    before every load, so the dependency points from the VFS into ffi and
    ffi never loads any VFS code. The reader hands the library's bytes to
    the native constructor, which loads them from the same kind of image,
    released right after the load, while library.path keeps reporting the
    virtual path. Libraries on the real file system are unaffected and
    load directly, and pay only a null check while no VFS is mounted.
    
    The AddonImage materializer moves from an anonymous namespace in
    node_binding.cc to node_binding.h so that node_ffi.cc can reuse it.
    On Windows the image is now written and closed before the load,
    because the loader shares read alone and a retained writable
    delete-on-close handle failed the load with ERROR_SHARING_VIOLATION;
    since a mapped image cannot be unlinked there, it is kept with the
    module it loaded as and both are released at process exit. On POSIX
    the image still never outlives the constructor call, so nothing is
    left for dlclose() to clean up.
    
    Also fix the VFS dlopen hook forwarding a missing flags argument as
    undefined, which process.dlopen() coerces to 0 - not a valid
    dlopen(2) mode - so loading any addon from the real file system
    failed with EINVAL while a VFS was mounted.
    
    Co-authored-by: Philipp Dunkel <pipobscure@users.noreply.github.com>
    Signed-off-by: Matteo Collina <hello@matteocollina.com>
    PR-URL: #65909
    Reviewed-By: Paolo Insogna <paolo@cowtech.it>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    mcollina and pipobscure authored Sep 15, 2026
    Configuration menu
    Copy the full SHA
    a4bb025 View commit details
    Browse the repository at this point in the history
  4. test: fix stderr Buffer assertion in exec encoding test

    Signed-off-by: greenhead <greenheadhq@gmail.com>
    PR-URL: #66008
    Refs: #10919
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
    Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
    greenheadHQ authored and panva committed Sep 15, 2026
    Configuration menu
    Copy the full SHA
    26dbe11 View commit details
    Browse the repository at this point in the history
  5. quic: fix readable stream truncation on stop-sending, abort & timeout

    Signed-off-by: Tim Perry <pimterry@gmail.com>
    PR-URL: #63967
    Reviewed-By: James M Snell <jasnell@gmail.com>
    pimterry authored Sep 15, 2026
    Configuration menu
    Copy the full SHA
    11ed325 View commit details
    Browse the repository at this point in the history
  6. tools: make checkout credential use explicit

    Disable credential persistence for CodeQL.
    
    Signed-off-by: Filip Skokan <panva.ip@gmail.com>
    Assisted-by: Codex
    PR-URL: #66013
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
    Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
    panva authored and nodejs-github-bot committed Sep 15, 2026
    Configuration menu
    Copy the full SHA
    67868c7 View commit details
    Browse the repository at this point in the history
  7. tools: correct Slack action version comments

    Signed-off-by: Filip Skokan <panva.ip@gmail.com>
    Assisted-by: Codex
    PR-URL: #66013
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
    Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
    panva authored and nodejs-github-bot committed Sep 15, 2026
    Configuration menu
    Copy the full SHA
    fe40b31 View commit details
    Browse the repository at this point in the history
  8. tools: use self-repository references

    Resolve local actions and reusable workflows from the running
    workflow commit with $/ references, independent of checkout paths.
    
    Remove the tarball job's action-only checkout and the WPT action
    checkout/copy workaround, which are no longer needed.
    
    Signed-off-by: Filip Skokan <panva.ip@gmail.com>
    Assisted-by: Codex
    PR-URL: #66013
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
    Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
    panva authored and nodejs-github-bot committed Sep 15, 2026
    Configuration menu
    Copy the full SHA
    96e769e View commit details
    Browse the repository at this point in the history
  9. tools: avoid workflow shell interpolation

    Pass input, output, and version values through environment variables
    instead of expanding them into shell source. Split benchmark
    categories and PR numbers into arrays to retain separate arguments.
    
    Signed-off-by: Filip Skokan <panva.ip@gmail.com>
    Assisted-by: Codex
    PR-URL: #66013
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
    Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
    panva authored and nodejs-github-bot committed Sep 15, 2026
    Configuration menu
    Copy the full SHA
    7203d9b View commit details
    Browse the repository at this point in the history
  10. doc: clarify QUIC async write backpressure

    Signed-off-by: John Finnerty <297514060+johnfinnerty-nz@users.noreply.github.com>
    PR-URL: #65947
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
    johnfinnerty-nz authored Sep 15, 2026
    Configuration menu
    Copy the full SHA
    fa10566 View commit details
    Browse the repository at this point in the history
  11. deps: update googletest to 8eff9e336692fc95961e096564f1044c600b881d

    PR-URL: #66009
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    nodejs-github-bot authored Sep 15, 2026
    Configuration menu
    Copy the full SHA
    dbfa70a View commit details
    Browse the repository at this point in the history
  12. test: deflake util.throttle tests

    Short throttle windows can expire between synchronous calls when the
    process is descheduled. Delayed timer dispatch can also release two
    queued calls together, invalidating the strict test's spacing assertion.
    
    Move timing checks to a separate test with mocked timers and a matching
    libuv clock. Cover both punctual and delayed dispatch, and keep real
    async_hooks timer-allocation checks with windows canceled before expiry.
    
    Signed-off-by: Filip Skokan <panva.ip@gmail.com>
    Assisted-by: Codex
    PR-URL: #66034
    Refs: #65899
    Refs: https://ci.nodejs.org/job/node-test-commit-linux-containered/nodes=ubuntu2404_sharedlibs_openssl111_x64/59189/
    Refs: https://ci.nodejs.org/job/node-test-commit-linuxone/nodes=rhel8-s390x/58602/
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    panva authored Sep 15, 2026
    Configuration menu
    Copy the full SHA
    84e9174 View commit details
    Browse the repository at this point in the history
  13. http2: settle pending write callbacks on destroy

    When a stream is destroyed while a write is still in flight, nghttp2 may
    have handed the data to the socket and never report the write completion
    once the stream or session tears down. That leaves the write callback
    unresolved, the Writable stuck, and the event loop never drains, which
    times out test-http2-close-while-writing on macOS.
    
    Settle the in-flight write in Http2Stream._destroy by invoking its
    callback with the destroy error and resetting writePending. A later
    native completion callback is then a no-op because writeCb is null and
    writePending is 0, so the settle is idempotent. Passing the error rather
    than null also drains any buffered writes.
    
    Fixes: #58252
    
    Signed-off-by: Matteo Collina <hello@matteocollina.com>
    Assisted-by: pi-coding-agent
    PR-URL: #66016
    Fixes: #58252
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
    mcollina authored Sep 15, 2026
    Configuration menu
    Copy the full SHA
    e13c138 View commit details
    Browse the repository at this point in the history
  14. src: ffi: create fast-call metadata Symbols lazily

    The FFI fast-call wrappers key per-function metadata on raw FFI
    functions using two per-isolate Symbols (kFastArguments /
    kFastBufferInvoke) that were declared in src/env_properties.h.
    Everything in env_properties.h is allocated while the startup
    snapshot is built, so each Symbol advances the isolate's
    identity-hash RNG before Object.prototype / Function.prototype
    receive their snapshot identity hashes. In the snapshot produced
    for Node 26.4.0+ this shifted those hashes so a function map (a
    function whose `length` was redefined) and a plain-object map (an
    object literal with an accessor) collide in V8's 64-slot
    NormalizedMapCache. Every store into such objects then misses
    the inline cache, and the repro reported in the linked issue is
    roughly 7x slower.
    
    Create the two Symbols lazily in the FFI binding's Initialize, on
    the first run of internalBinding('ffi') at runtime, instead of
    declaring them in env_properties.h. They are therefore not
    allocated during snapshot serialization and no longer bias the
    snapshot's prototype identity hashes. Their export, property
    layout, and the fast-call feature behavior are unchanged.
    
    Refs: #66011
    
    Signed-off-by: Matteo Collina <matteo.collina@gmail.com>
    Assisted-by: Pi
    PR-URL: #66015
    Reviewed-By: Paolo Insogna <paolo@cowtech.it>
    Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    mcollina authored Sep 15, 2026
    Configuration menu
    Copy the full SHA
    cfdb7e6 View commit details
    Browse the repository at this point in the history
  15. vfs: close the fs hook gaps for mounted paths

    Several `node:fs` entry points behave differently for a mounted path
    than for a real one, because of how the call reaches the VFS hooks.
    Make them behave as they do for a real path:
    
    * Add the `watchFile`, `unwatchFile` and `promisesWatch` handlers,
      backed by the provider's stat watcher and async watcher; those calls
      threw a TypeError before. Have `watch` refuse a path that does not
      exist with ENOENT instead of handing back a watcher that polls
      forever and keeps the process alive.
    * Convert timestamps and validate arguments before the hook runs in
      `utimes`, `lutimes` and `readdir` (sync, callback and promise forms),
      so a mounted path gets the same ERR_INVALID_ARG_* errors and the same
      seconds-since-epoch numbers as a real one.
    * Pass the mode and times through to the `fchmod` and `futimes` hooks
      and route them to the handle's entry, so descriptor operations take
      effect like their path forms instead of being no-ops; the memory
      handle validates the way a FileHandle would since one calls it
      directly.
    * Treat a `mkdtemp` prefix as text rather than a path when it ends in a
      separator, so the directory is created inside the intended parent.
    * Map the first directory a recursive `mkdir` created back under the
      mount point instead of returning the provider-relative path.
    * Make disposing an already closed virtual `Dir` a no-op, as on the
      native `Dir`, instead of rejecting with ERR_DIR_CLOSED.
    
    test-vfs-fs-hook-gaps adds a test per gap, stating the real-fs outcome
    as the expectation. The existing file handle test asserted that
    `chmod()` and `utimes()` without arguments were no-ops; they now
    validate and apply, so it exercises that instead.
    
    Signed-off-by: Philipp Dunkel <pip@pipobscure.com>
    PR-URL: #65852
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    pipobscure authored Sep 15, 2026
    Configuration menu
    Copy the full SHA
    ea51c14 View commit details
    Browse the repository at this point in the history
  16. test: cover cpSync fast path timestamp preservation

    Add test coverage for the native cpSync fast path to ensure it matches
    the existing timestamp preservation behavior.
    
    Signed-off-by: Abhinandan Kumar <abhi128618@gmail.com>
    PR-URL: #65678
    Reviewed-By: LiviaMedeiros <livia@cirno.name>
    abhi128nandan authored Sep 15, 2026
    Configuration menu
    Copy the full SHA
    efc612d View commit details
    Browse the repository at this point in the history
  17. test: prevent parser reuse across close scenarios

    Both cases replace parser cleanup methods. Faster socket cleanup can
    return a modified parser to the shared pool and close it before the
    other request uses it.
    
    Run the immediate and deferred close cases in separate test files so
    each gets its own process and parser pool. Preserve both cleanup paths
    and all call-count assertions.
    
    Signed-off-by: Filip Skokan <panva.ip@gmail.com>
    Assisted-by: Codex
    PR-URL: #66017
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
    Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    panva authored Sep 15, 2026
    Configuration menu
    Copy the full SHA
    5c5bd22 View commit details
    Browse the repository at this point in the history
  18. build, doc: move to redesign

    Signed-off-by: Aviv Keller <me@aviv.sh>
    PR-URL: #62045
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    Reviewed-By: Tim Perry <pimterry@gmail.com>
    avivkeller committed Sep 15, 2026
    Configuration menu
    Copy the full SHA
    18a9ba5 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2026

  1. lib,src: apply multiple updates to dtls implementation

    Signed-off-by: James M Snell <jasnell@gmail.com>
    Assisted-by: Opecode
    PR-URL: #65511
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    jasnell committed Sep 16, 2026
    Configuration menu
    Copy the full SHA
    bd2b98f View commit details
    Browse the repository at this point in the history
Loading