src: remove unused guards around node-api reference

legendecas · BethGriggs · commit fc138376aa0d · 2021-07-29T11:56:43.000+01:00
PR-URL: #38334 Reviewed-By: Michael Dawson <midawson@redhat.com>
diff --git a/src/js_native_api_v8.cc b/src/js_native_api_v8.cc
@@ -627,9 +627,6 @@ v8::Local<v8::Value> Reference::Get() {
 }
 
 void Reference::Finalize(bool is_env_teardown) {
-  if (is_env_teardown) env_teardown_finalize_started_ = true;
-  if (!is_env_teardown && env_teardown_finalize_started_) return;
-
   // During env teardown, `~napi_env()` alone is responsible for finalizing.
   // Thus, we don't want any stray gc passes to trigger a second call to
   // `RefBase::Finalize()`. ClearWeak will ensure that even if the
diff --git a/src/js_native_api_v8.h b/src/js_native_api_v8.h
@@ -433,7 +433,6 @@ class Reference : public RefBase {
   static void SecondPassCallback(
       const v8::WeakCallbackInfo<SecondPassCallParameterRef>& data);
 
-  bool env_teardown_finalize_started_ = false;
   v8impl::Persistent<v8::Value> _persistent;
   SecondPassCallParameterRef* _secondPassParameter;
   bool _secondPassScheduled;

Original file line number	Diff line number	Diff line change
`@@ -627,9 +627,6 @@ v8::Local<v8::Value> Reference::Get() {`
`627`	`627`	`}`
`628`	`628`
`629`	`629`	`void Reference::Finalize(bool is_env_teardown) {`
`630`		`- if (is_env_teardown) env_teardown_finalize_started_ = true;`
`631`		`- if (!is_env_teardown && env_teardown_finalize_started_) return;`
`632`		`-`
`633`	`630`	// During env teardown, `~napi_env()` alone is responsible for finalizing.
`634`	`631`	`// Thus, we don't want any stray gc passes to trigger a second call to`
`635`	`632`	// `RefBase::Finalize()`. ClearWeak will ensure that even if the