test: use Number.isNaN instead of global isNaN

mithunsasidharan · gibfahn · commit ed13aac2ab66 · 2017-12-20T00:58:00.000Z
PR-URL: #17515 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
diff --git a/test/parallel/test-os.js b/test/parallel/test-os.js
@@ -28,7 +28,7 @@ const { inspect } = require('util');
 
 const is = {
   number: (value, key) => {
-    assert(!isNaN(value), `${key} should not be NaN`);
+    assert(!Number.isNaN(value), `${key} should not be NaN`);
     assert.strictEqual(typeof value, 'number');
   },
   string: (value) => { assert.strictEqual(typeof value, 'string'); },
diff --git a/test/parallel/test-readdouble.js b/test/parallel/test-readdouble.js
@@ -72,12 +72,12 @@ function test(clazz) {
   buffer[5] = 0xff;
   buffer[6] = 0x0f;
   buffer[7] = 0x00;
-  assert.ok(isNaN(buffer.readDoubleBE(0)));
+  assert.ok(Number.isNaN(buffer.readDoubleBE(0)));
   assert.strictEqual(2.225073858507201e-308, buffer.readDoubleLE(0));
 
   buffer[6] = 0xef;
   buffer[7] = 0x7f;
-  assert.ok(isNaN(buffer.readDoubleBE(0)));
+  assert.ok(Number.isNaN(buffer.readDoubleBE(0)));
   assert.strictEqual(1.7976931348623157e+308, buffer.readDoubleLE(0));
 
   buffer[0] = 0;
diff --git a/test/parallel/test-writefloat.js b/test/parallel/test-writefloat.js
@@ -127,8 +127,8 @@ function test(clazz) {
   // Darwin ia32 does the other kind of NaN.
   // Compiler bug.  No one really cares.
   assert(0x7F === buffer[7] || 0xFF === buffer[7]);
-  assert.ok(isNaN(buffer.readFloatBE(0)));
-  assert.ok(isNaN(buffer.readFloatLE(4)));
+  assert.ok(Number.isNaN(buffer.readFloatBE(0)));
+  assert.ok(Number.isNaN(buffer.readFloatLE(4)));
 }
 
 

Original file line number	Diff line number	Diff line change
`@@ -127,8 +127,8 @@ function test(clazz) {`
`127`	`127`	`// Darwin ia32 does the other kind of NaN.`
`128`	`128`	`// Compiler bug. No one really cares.`
`129`	`129`	`assert(0x7F === buffer[7] \|\| 0xFF === buffer[7]);`
`130`		`- assert.ok(isNaN(buffer.readFloatBE(0)));`
`131`		`- assert.ok(isNaN(buffer.readFloatLE(4)));`
	`130`	`+ assert.ok(Number.isNaN(buffer.readFloatBE(0)));`
	`131`	`+ assert.ok(Number.isNaN(buffer.readFloatLE(4)));`
`132`	`132`	`}`
`133`	`133`
`134`	`134`