util: move util.isBuffer to eol

marco-ippolito · nodejs-github-bot · commit e32b0c1eab97 · 2024-05-06T09:37:59.000Z
PR-URL: #52744 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/doc/api/deprecations.md b/doc/api/deprecations.md
@@ -1023,6 +1023,9 @@ The `util.isBoolean()` API has been removed. Please use
 
 <!-- YAML
 changes:
+  - version: REPLACEME
+    pr-url: https://github.com/nodejs/node/pull/52744
+    description: End-of-Life deprecation.
   - version: v22.0.0
     pr-url: https://github.com/nodejs/node/pull/50488
     description: Runtime deprecation.
@@ -1038,9 +1041,9 @@ changes:
     description: Documentation-only deprecation.
 -->
 
-Type: Runtime
+Type: End-of-Life
 
-The [`util.isBuffer()`][] API is deprecated. Please use
+The `util.isBuffer()` API has been removed. Please use
 [`Buffer.isBuffer()`][] instead.
 
 ### DEP0047: `util.isDate()`
@@ -3779,8 +3782,6 @@ is deprecated to better align with recommendations per [NIST SP 800-38D][].
 [`util.inspect()`]: util.md#utilinspectobject-options
 [`util.inspect.custom`]: util.md#utilinspectcustom
 [`util.isArray()`]: util.md#utilisarrayobject
-[`util.isBuffer()`]: util.md#utilisbufferobject
-[`util.isDate()`]: util.md#utilisdateobject
 [`util.isError()`]: util.md#utiliserrorobject
 [`util.isFunction()`]: util.md#utilisfunctionobject
 [`util.isNull()`]: util.md#utilisnullobject
diff --git a/doc/api/util.md b/doc/api/util.md
@@ -2950,31 +2950,6 @@ util.isArray({});
 // Returns: false
 ```
 
-### `util.isBuffer(object)`
-
-<!-- YAML
-added: v0.11.5
-deprecated: v4.0.0
--->
-
-> Stability: 0 - Deprecated: Use [`Buffer.isBuffer()`][] instead.
-
-* `object` {any}
-* Returns: {boolean}
-
-Returns `true` if the given `object` is a `Buffer`. Otherwise, returns `false`.
-
-```js
-const util = require('node:util');
-
-util.isBuffer({ length: 0 });
-// Returns: false
-util.isBuffer([]);
-// Returns: false
-util.isBuffer(Buffer.from('hello world'));
-// Returns: true
-```
-
 ### `util.isDate(object)`
 
 <!-- YAML
@@ -3355,7 +3330,6 @@ util.log('Timestamped message.');
 [`Array.isArray()`]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/isArray
 [`ArrayBuffer.isView()`]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/ArrayBuffer/isView
 [`ArrayBuffer`]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/ArrayBuffer
-[`Buffer.isBuffer()`]: buffer.md#static-method-bufferisbufferobj
 [`DataView`]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/DataView
 [`Date`]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Date
 [`Error`]: errors.md#class-error
diff --git a/lib/util.js b/lib/util.js
@@ -70,7 +70,6 @@ const {
   validateString,
   validateOneOf,
 } = require('internal/validators');
-const { isBuffer } = require('buffer').Buffer;
 const types = require('internal/util/types');
 const binding = internalBinding('util');
 
@@ -410,9 +409,6 @@ module.exports = {
   isArray: deprecate(ArrayIsArray,
                      'The `util.isArray` API is deprecated. Please use `Array.isArray()` instead.',
                      'DEP0044'),
-  isBuffer: deprecate(isBuffer,
-                      'The `util.isBuffer` API is deprecated. Please use `Buffer.isBuffer()` instead.',
-                      'DEP0046'),
   isDeepStrictEqual(a, b) {
     if (internalDeepEqual === undefined) {
       internalDeepEqual = require('internal/util/comparisons')
diff --git a/test/parallel/test-util.js b/test/parallel/test-util.js
@@ -98,10 +98,6 @@ assert.strictEqual(util.isPrimitive(Infinity), true);
 assert.strictEqual(util.isPrimitive(NaN), true);
 assert.strictEqual(util.isPrimitive(Symbol('symbol')), true);
 
-// isBuffer
-assert.strictEqual(util.isBuffer('foo'), false);
-assert.strictEqual(util.isBuffer(Buffer.from('foo')), true);
-
 assert.strictEqual(util.isNull(null), true);
 assert.strictEqual(util.isNull(undefined), false);
 assert.strictEqual(util.isNull(), false);
