util: runtime deprecate util.isPrimitive

marco-ippolito · nodejs-github-bot · commit e0b8de78edda · 2023-11-27T13:39:21.000Z
PR-URL: #50488 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
diff --git a/doc/api/deprecations.md b/doc/api/deprecations.md
@@ -1198,6 +1198,9 @@ The [`util.isObject()`][] API is deprecated.
 
 <!-- YAML
 changes:
+  - version: REPLACEME
+    pr-url: https://github.com/nodejs/node/pull/50488
+    description: Runtime deprecation.
   - version:
     - v6.12.0
     - v4.8.6
@@ -1210,7 +1213,7 @@ changes:
     description: Documentation-only deprecation.
 -->
 
-Type: Documentation-only
+Type: Runtime
 
 The [`util.isPrimitive()`][] API is deprecated.
 
diff --git a/lib/util.js b/lib/util.js
@@ -441,7 +441,11 @@ module.exports = {
   isFunction: deprecate(isFunction,
                         'The `util.isFunction` API is deprecated.  Please use `typeof arg === "function"` instead.',
                         'DEP0049'),
-  isPrimitive: deprecate(isPrimitive, 'The `util.isPrimitive API is deprecated.', 'DEP0054'),
+  isPrimitive: deprecate(isPrimitive,
+                         'The `util.isPrimitive` API is deprecated. ' +
+                         'Please use `arg === null || ' +
+                         '(typeof arg !== "object" && typeof arg !== "function")` instead.',
+                         'DEP0054'),
   log: deprecate(log, 'The `util.log API is deprecated.', 'DEP0059'),
   promisify,
   stripVTControlCharacters,
