Skip to content

Commit d3f4ed9

Browse files
richardlauaduh95
authored andcommitted
build: suppress compiler warnings for histogram
Synchronize compiler flags in the gyp build and unofficial gn build of `deps/histogram`. Signed-off-by: Richard Lau <richard.lau@ibm.com> PR-URL: #63980 Fixes: #63979 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
1 parent 6577d3b commit d3f4ed9

1 file changed

Lines changed: 23 additions & 0 deletions

File tree

deps/histogram/histogram.gyp

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,29 @@
1313
'xcode_settings': {
1414
'GCC_SYMBOLS_PRIVATE_EXTERN': 'YES', # -fvisibility=hidden
1515
},
16+
'conditions': [
17+
[ 'clang==1', {
18+
'conditions': [
19+
[ 'OS=="win"', {
20+
'msvs_settings': {
21+
'VCCLCompilerTool': {
22+
'AdditionalOptions': [
23+
'-Wno-atomic-alignment',
24+
'-Wno-incompatible-pointer-types',
25+
'-Wno-unused-function'
26+
],
27+
},
28+
},
29+
}, {
30+
'cflags': [
31+
'-Wno-atomic-alignment',
32+
'-Wno-incompatible-pointer-types',
33+
'-Wno-unused-function'
34+
],
35+
}],
36+
],
37+
}],
38+
],
1639
'include_dirs': ['src', 'include'],
1740
'direct_dependent_settings': {
1841
'include_dirs': [ 'src', 'include' ]

0 commit comments

Comments
 (0)