typings: fix ImportModuleDynamicallyCallback return type

legendecas · targos · commit c6d6be2c3bba · 2025-02-25T17:51:02.000+01:00
PR-URL: #57160 Refs: https://github.com/nodejs/node/pull/56919/files#r1955336054 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/lib/internal/modules/esm/loader.js b/lib/internal/modules/esm/loader.js
@@ -323,7 +323,7 @@ class ModuleLoader {
    * @param {string} source Source code. TODO(joyeecheung): pass the raw buffer.
    * @param {string} isMain Whether this module is a main module.
    * @param {CJSModule|undefined} parent Parent module, if any.
-   * @returns {{wrap: ModuleWrap, namespace: ModuleNamespaceObject}}
+   * @returns {{wrap: ModuleWrap, namespace: import('internal/modules/esm/utils').ModuleNamespaceObject}}
    */
   importSyncForRequire(mod, filename, source, isMain, parent) {
     const url = pathToFileURL(filename).href;
diff --git a/lib/internal/modules/esm/utils.js b/lib/internal/modules/esm/utils.js
@@ -101,12 +101,18 @@ function getConditionsSet(conditions) {
   return getDefaultConditionsSet();
 }
 
+/**
+ * @typedef {{
+ *   [Symbol.toStringTag]: 'Module',
+ * }} ModuleNamespaceObject
+ */
+
 /**
  * @callback ImportModuleDynamicallyCallback
  * @param {string} specifier
  * @param {ModuleWrap|ContextifyScript|Function|vm.Module} callbackReferrer
  * @param {Record<string, string>} attributes
- * @returns { Promise<void> }
+ * @returns {Promise<ModuleNamespaceObject>}
  */
 
 /**
