http, readline: replace sort with toSorted

benjamingr · aduh95 · commit b13aea569874 · 2024-07-16T12:01:16.000+02:00
PR-URL: #53623 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/lib/internal/readline/utils.js b/lib/internal/readline/utils.js
@@ -1,8 +1,7 @@
 'use strict';
 
 const {
-  ArrayPrototypeSlice,
-  ArrayPrototypeSort,
+  ArrayPrototypeToSorted,
   RegExpPrototypeExec,
   StringFromCharCode,
   StringPrototypeCharCodeAt,
@@ -385,7 +384,7 @@ function commonPrefix(strings) {
   if (strings.length === 1) {
     return strings[0];
   }
-  const sorted = ArrayPrototypeSort(ArrayPrototypeSlice(strings));
+  const sorted = ArrayPrototypeToSorted(strings);
   const min = sorted[0];
   const max = sorted[sorted.length - 1];
   for (let i = 0; i < min.length; i++) {
diff --git a/typings/primordials.d.ts b/typings/primordials.d.ts
@@ -128,6 +128,7 @@ declare namespace primordials {
   export const ArrayPrototypeSlice: UncurryThis<typeof Array.prototype.slice>
   export const ArrayPrototypeSort: UncurryThis<typeof Array.prototype.sort>
   export const ArrayPrototypeSplice: UncurryThis<typeof Array.prototype.splice>
+  export const ArrayPrototypeToSorted: UncurryThis<typeof Array.prototype.toSorted>
   export const ArrayPrototypeIncludes: UncurryThis<typeof Array.prototype.includes>
   export const ArrayPrototypeIndexOf: UncurryThis<typeof Array.prototype.indexOf>
   export const ArrayPrototypeJoin: UncurryThis<typeof Array.prototype.join>
