src: break out of timers loop if !can_call_into_js()

addaleax · MylesBorins · commit afc811cc1cc1 · 2018-06-06T14:28:08.000+02:00
Otherwise, this turns into an infinite loop when the flag is set, because it makes `MakeCallback()` return immediately. Backport-PR-URL: #21168 PR-URL: #20884 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
diff --git a/src/timer_wrap.cc b/src/timer_wrap.cc
@@ -148,6 +148,7 @@ class TimerWrap : public HandleWrap {
                 .ToLocalChecked();
     } while (ret->IsUndefined() &&
              !env->tick_info()->has_thrown() &&
+             env->can_call_into_js() &&
              wrap->object()->Get(env->context(),
                                  env->owner_string()).ToLocalChecked()
                                                      ->IsUndefined());
