test: print stack immediately avoiding GC interleaving

legendecas · aduh95 · commit adce20c0a19f · 2026-02-08T10:10:46.000+01:00
`require(mod)` does not keep the mod in require cache if mod throws synchronously. This fixes the tests to print the stack immediately in case that source map cache could be cleaned up when the CJS module is reclaimed by GC in the next event loop tick. PR-URL: #61699 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
diff --git a/lib/internal/source_map/source_map_cache_map.js b/lib/internal/source_map/source_map_cache_map.js
@@ -13,6 +13,9 @@ const {
     source_map_data_private_symbol,
   },
 } = internalBinding('util');
+let debug = require('internal/util/debuglog').debuglog('source_map', (fn) => {
+  debug = fn;
+});
 
 /**
  * Specialized map of WeakRefs to module instances that caches source map
@@ -46,6 +49,7 @@ class SourceMapCacheMap {
     ArrayPrototypeForEach(keys, (key) => {
       const ref = this.#weakModuleMap.get(key);
       if (ref && ref.deref() === undefined) {
+        debug(`Cleanup obsolete source map cache entry with key: ${key}`);
         this.#weakModuleMap.delete(key);
       }
     });
diff --git a/test/fixtures/source-map/output/source_map_sourcemapping_url_string.js b/test/fixtures/source-map/output/source_map_sourcemapping_url_string.js
@@ -7,7 +7,5 @@ Error.stackTraceLimit = 2;
 try {
   require('../typescript-sourcemapping_url_string');
 } catch (err) {
-  setTimeout(() => {
-    console.info(err);
-  }, 10);
+  console.info(err);
 }
diff --git a/test/fixtures/source-map/output/source_map_throw_catch.js b/test/fixtures/source-map/output/source_map_throw_catch.js
@@ -7,7 +7,5 @@ Error.stackTraceLimit = 2;
 try {
   require('../typescript-throw');
 } catch (err) {
-  setTimeout(() => {
-    console.info(err);
-  }, 10);
+  console.info(err);
 }

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,5 @@ Error.stackTraceLimit = 2;`
`7`	`7`	`try {`
`8`	`8`	`require('../typescript-sourcemapping_url_string');`
`9`	`9`	`} catch (err) {`
`10`		`- setTimeout(() => {`
`11`		`- console.info(err);`
`12`		`- }, 10);`
	`10`	`+ console.info(err);`
`13`	`11`	`}`
Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,5 @@ Error.stackTraceLimit = 2;`
`7`	`7`	`try {`
`8`	`8`	`require('../typescript-throw');`
`9`	`9`	`} catch (err) {`
`10`		`- setTimeout(() => {`
`11`		`- console.info(err);`
`12`		`- }, 10);`
	`10`	`+ console.info(err);`
`13`	`11`	`}`