Skip to content

Commit ab1e785

Browse files
nodejs-github-botaduh95
authored andcommitted
tools: update nixpkgs pins
- unstable to 085af13c1607f4f73ab1e7a51071faf6577a7e87 - 26.05 to 57f1c8965649ce5bcac5118a0d2e41f1fbdc56e5 PR-URL: #67334 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
1 parent ffed2aa commit ab1e785

5 files changed

Lines changed: 18 additions & 27 deletions

File tree

‎.github/workflows/nix-changes.yml‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,12 @@ jobs:
6868

6969
- name: Compute requisites after change
7070
run: ./tools/nix/list-requisites.sh > requisites-${{ matrix.system }}-after.list
71+
env:
72+
# Making sure we do not depend on eval-time fetches, which are not cached.
73+
# The only exception is nixpkgs source tarballs.
74+
NIX_CONFIG: |
75+
restrict-eval = true
76+
allowed-uris = https://github.com/NixOS/nixpkgs/archive/
7177
7278
- name: Compute requisites before change
7379
run: |

‎tools/nix/ci-shell.nix‎

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,13 +46,17 @@ args@{
4646
)
4747
}-pkg-config-only"
4848
{
49+
__structuredAttrs = true;
50+
strictDeps = true;
4951
nativeBuildInputs = [ pkgs.pkgconf ];
5052
buildInputs = [ dep ];
53+
outputChecks.out.disallowedRequisites = [ pkgs.pkgconf ];
5154
}
5255
''
5356
mkdir -p "$out/lib/pkgconfig"
54-
for pc in $(pkgconf --list-package-names); do
55-
ln -s "$(pkgconf --path "$pc")" "$out/lib/pkgconfig/"
57+
for pc in $(pkgconf --env-only --list-package-names); do
58+
PC_PATH="$(pkgconf --path "$pc")"
59+
[ -z "$PC_PATH" ] || ln -s "$PC_PATH" "$out/lib/pkgconfig/"
5660
done
5761
''
5862
) old.buildInputs;

‎tools/nix/list-requisites.sh‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ set -ex
44

55
BASE_DIR=$(cd "$(dirname "$0")/../.." && pwd)
66

7-
OPTIONAL_FLAGS=$(nix-instantiate -I "nixpkgs=$BASE_DIR/tools/nix/pkgs.nix" --eval --strict --raw -E "
7+
OPTIONAL_FLAGS=$(nix-instantiate -I "$BASE_DIR" -I "nixpkgs=$BASE_DIR/tools/nix/pkgs.nix" --eval --strict --raw -E "
88
(import <nixpkgs> {}).lib.concatMapStrings
99
(n: ''--arg \${n} true '')
1010
(builtins.filter
@@ -16,7 +16,7 @@ OPTIONAL_FLAGS=$(nix-instantiate -I "nixpkgs=$BASE_DIR/tools/nix/pkgs.nix" --eva
1616
DRV=$(
1717
cd "$BASE_DIR"
1818
# shellcheck disable=SC2086
19-
nix-instantiate -I "nixpkgs=./tools/nix/pkgs.nix" shell.nix \
19+
nix-instantiate -I. -I "nixpkgs=./tools/nix/pkgs.nix" shell.nix \
2020
$OPTIONAL_FLAGS \
2121
--arg sharedLibDeps '{
2222
# Using an empty set as some build dependencies are required only in the absence of shared deps (e.g. Cargo).

‎tools/nix/pkgs-26.05.nix‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
arg:
22
let
33
repo = "https://github.com/NixOS/nixpkgs";
4-
rev = "c0ae35c6460f00dcac6a59063e080f826e620b28";
4+
rev = "57f1c8965649ce5bcac5118a0d2e41f1fbdc56e5";
55
nixpkgs = import (builtins.fetchTarball {
66
url = "${repo}/archive/${rev}.tar.gz";
7-
sha256 = "0hbdqzpiv8p44li7jng01mlg2zbb1ff18z3r250f4rjbqflbiwxs";
7+
sha256 = "08gxbi52psc9wvflpfsli9fjvcv1jvzd70w6c8pxl4swjvfcsq3d";
88
}) arg;
99
in
1010
# Unstable channel no longer supports Intel architecture for macOS. We can use the 26.05 channel

‎tools/nix/pkgs.nix‎

Lines changed: 2 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
arg:
22
let
33
repo = "https://github.com/NixOS/nixpkgs";
4-
rev = "0bb2eedc20e4739f29e8045034f2828ad7054f8f";
4+
rev = "085af13c1607f4f73ab1e7a51071faf6577a7e87";
55
nixpkgs = import (builtins.fetchTarball {
66
url = "${repo}/archive/${rev}.tar.gz";
7-
sha256 = "008j4dj5yrzww91qvp1lp2c9d1lkwc6i2dpainf5nkdkr3rwj8vy";
7+
sha256 = "0wwdfxvwc19qymmjshf8qzw39dqyav1kgxna2ady9l7akqzanm1i";
88
}) arg;
99
in
1010
# Unstable channel no longer supports Intel architecture for macOS. We can use the 26.05 channel
@@ -38,23 +38,4 @@ else
3838
Cflags: -I${lib.getInclude boringssl}/include
3939
'';
4040
};
41-
42-
# TODO: remove pin once https://github.com/mozilla/sccache/issues/2869 is resolved
43-
sccache = nixpkgs.callPackage (builtins.fetchurl {
44-
url = "${repo}/raw/aff8a0b28396750446e5537a96461bc4facdb287/pkgs/by-name/sc/sccache/package.nix";
45-
sha256 = "09dlc99sam9ld9jvzgcc00r4v4ls1cmbb0yim3mr895fpbs8b3qa";
46-
}) { };
47-
48-
# TODO: remove this override once the pin we use has picked up https://github.com/NixOS/nixpkgs/pull/575002
49-
uvwasi = nixpkgs.uvwasi.overrideAttrs (old: {
50-
patches = old.patches ++ [
51-
(nixpkgs.fetchpatch2 {
52-
url = "https://github.com/nodejs/uvwasi/commit/fe602a6911207efd8dcfc070a752bcf76813c978.patch?full_index=1";
53-
hash = "sha256-MyFvRuEhcqZR+Bz2pY9vani8U1iyQrDeni2kKKnJGEI=";
54-
})
55-
];
56-
57-
buildInputs = [ ];
58-
propagatedBuildInputs = old.buildInputs;
59-
});
6041
}

0 commit comments

Comments
 (0)