repl: display error message when loading directory

princejwesley · JungMinu · commit aad6b9f0ebf7 · 2015-12-11T10:21:14.000+09:00
When loading directory instead of file, no error message is displayed. It's good to display error message for this scenario. PR-URL: #4170 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
diff --git a/lib/repl.js b/lib/repl.js
@@ -1082,6 +1082,9 @@ function defineDefaultCommands(repl) {
               self.write(line + '\n');
             }
           });
+        } else {
+          this.outputStream.write('Failed to load:' + file +
+                                  ' is not a valid file\n');
         }
       } catch (e) {
         this.outputStream.write('Failed to load:' + file + '\n');
diff --git a/test/parallel/test-repl-.save.load.js b/test/parallel/test-repl-.save.load.js
@@ -61,6 +61,14 @@ putIn.write = function(data) {
 };
 putIn.run(['.load ' + loadFile]);
 
+// throw error on loading directory
+loadFile = common.tmpDir;
+putIn.write = function(data) {
+  assert.equal(data, 'Failed to load:' + loadFile + ' is not a valid file\n');
+  putIn.write = function() {};
+};
+putIn.run(['.load ' + loadFile]);
+
 // clear the REPL
 putIn.run(['.clear']);
 

Original file line number	Diff line number	Diff line change
`@@ -1082,6 +1082,9 @@ function defineDefaultCommands(repl) {`
`1082`	`1082`	`self.write(line + '\n');`
`1083`	`1083`	`}`
`1084`	`1084`	`});`
	`1085`	`+ } else {`
	`1086`	`+ this.outputStream.write('Failed to load:' + file +`
	`1087`	`+ ' is not a valid file\n');`
`1085`	`1088`	`}`
`1086`	`1089`	`} catch (e) {`
`1087`	`1090`	`this.outputStream.write('Failed to load:' + file + '\n');`